Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[zh-cn]: update translation of Set.entries()&keys()&values() #16502

Merged
merged 2 commits into from
Oct 26, 2023
Merged

[zh-cn]: update translation of Set.entries()&keys()&values() #16502

merged 2 commits into from
Oct 26, 2023

Conversation

JasonLamv-t
Copy link
Member

@JasonLamv-t JasonLamv-t commented Oct 11, 2023 •
edited
Loading

Description

Same as the title.

Motivation

Ditto.

Additional details

None.

Related issues and pull requests

@github-actions github-actions bot added the l10n-zh Issues related to Chinese content. label Oct 11, 2023
@JasonLamv-t JasonLamv-t mentioned this pull request Oct 11, 2023
Closed
13 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2023 •
edited
Loading

Preview URLs

Flaws (4)

URL: /zh-CN/docs/Web/JavaScript/Reference/Global_Objects/Set/values
Title: Set.prototype.values()
Flaw count: 1

  • broken_links:
    • Can use the English (en-US) link as a fallback

URL: /zh-CN/docs/Web/JavaScript/Reference/Global_Objects/Set/entries
Title: Set.prototype.entries()
Flaw count: 2

  • broken_links:
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback

URL: /zh-CN/docs/Web/JavaScript/Reference/Global_Objects/Set/keys
Title: Set.prototype.keys()
Flaw count: 1

  • broken_links:
    • Can use the English (en-US) link as a fallback

(comment last updated: 2023-10-24 14:55:45)

@JasonLamv-t JasonLamv-t marked this pull request as ready for review October 24, 2023 02:57
@JasonLamv-t JasonLamv-t requested a review from a team as a code owner October 24, 2023 02:57
@JasonLamv-t JasonLamv-t requested review from jasonren0403 and removed request for a team October 24, 2023 02:57
jasonren0403
jasonren0403 reviewed Oct 24, 2023
View reviewed changes
Copy link
Contributor

@jasonren0403 jasonren0403 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

抱歉刚刚看到，这里有一些建议

files/zh-cn/web/javascript/reference/global_objects/set/entries/index.md Outdated Show resolved Hide resolved
jasonren0403
jasonren0403 approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@jasonren0403 jasonren0403 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jasonren0403 jasonren0403 merged commit 95f0eb2 into mdn:main Oct 26, 2023
7 checks passed
@JasonLamv-t JasonLamv-t deleted the set-iterator branch October 26, 2023 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonren0403 jasonren0403 jasonren0403 approved these changes

Assignees
No one assigned
Labels
l10n-zh Issues related to Chinese content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JasonLamv-t @jasonren0403