Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ko] fix to markdown format and etc. #16660

Merged
merged 5 commits into from
Oct 23, 2023
Merged

[ko] fix to markdown format and etc. #16660

merged 5 commits into from
Oct 23, 2023

Conversation

coolengineer
Copy link
Contributor

  • change pre tags to "```"
  • revert html entity escaped strings to original symbol ("<" -> "<")
  • fix minor typos
  • translate one line

Description

  • This change enables embeded code snippets to work correctly.
  • And minor glitches are fixed to render the page

Motivation

  • When I read the pages in Korean, some examples are not displayed.

@coolengineer coolengineer requested a review from a team as a code owner October 21, 2023 02:23
@coolengineer coolengineer requested review from cos18 and removed request for a team October 21, 2023 02:23
@github-actions github-actions bot added the l10n-ko Issues related to Korean content. label Oct 21, 2023
github-actions[bot]
github-actions bot reviewed Oct 21, 2023
View reviewed changes
files/ko/web/api/canvas_api/tutorial/applying_styles_and_colors/index.md Outdated Show resolved Hide resolved
files/ko/web/api/canvas_api/tutorial/applying_styles_and_colors/index.md Outdated Show resolved Hide resolved
files/ko/web/api/canvas_api/tutorial/applying_styles_and_colors/index.md Outdated Show resolved Hide resolved
files/ko/web/api/canvas_api/tutorial/applying_styles_and_colors/index.md Outdated Show resolved Hide resolved
files/ko/web/api/canvas_api/tutorial/applying_styles_and_colors/index.md Outdated Show resolved Hide resolved
files/ko/web/api/canvas_api/tutorial/applying_styles_and_colors/index.md Outdated Show resolved Hide resolved
files/ko/web/api/canvas_api/tutorial/applying_styles_and_colors/index.md Outdated Show resolved Hide resolved
@coolengineer
[ko] fix to markdown format and etc.
f223d4a 
* change pre tags to "```"
* revert html entity escaped strings to original symbol ("&#x3C;" -> "<")
* fix minor typos
* translate one line
@coolengineer
Apply lint suggestions
83644e2
@github-actions
Copy link
Contributor

github-actions bot commented Oct 22, 2023 •
edited
Loading

Preview URLs

Flaws (28)

URL: /ko/docs/Web/API/Canvas_API/Tutorial/Applying_styles_and_colors
Title: 스타일과 색 적용하기
Flaw count: 28

  • macros:
    • /ko/docs/Web/API/CanvasRenderingContext2D/fillStyle does not exist but fell back to /en-US/docs/Web/API/CanvasRenderingContext2D/fillStyle
    • /ko/docs/Web/API/CanvasRenderingContext2D/strokeStyle does not exist but fell back to /en-US/docs/Web/API/CanvasRenderingContext2D/strokeStyle
    • /ko/docs/Web/API/CanvasRenderingContext2D/globalAlpha does not exist but fell back to /en-US/docs/Web/API/CanvasRenderingContext2D/globalAlpha
    • /ko/docs/Web/API/CanvasRenderingContext2D/lineWidth does not exist but fell back to /en-US/docs/Web/API/CanvasRenderingContext2D/lineWidth
    • /ko/docs/Web/API/CanvasRenderingContext2D/lineCap does not exist but fell back to /en-US/docs/Web/API/CanvasRenderingContext2D/lineCap
    • and 19 more flaws omitted
  • broken_links:
    • Can't resolve /ko/docs/Web/HTML/Canvas/Tutorial/Drawing_shapes
    • Can't resolve /ko/docs/docs/Web/API/Canvas_API/Tutorial/Basic_animations
    • Can't resolve /ko/docs/docs/Web/API/Canvas_API/Tutorial/Compositing
  • translation_differences:
    • Differences in the important macros (13 in common of 19 possible)

(comment last updated: 2023-10-22 09:15:51)

github-actions[bot]
github-actions bot reviewed Oct 22, 2023
View reviewed changes
files/ko/web/api/canvas_api/tutorial/applying_styles_and_colors/index.md Outdated

{{EmbedLiveSample("A_createConicGradient_example", "180", "180", "canvas_conicgrad.png")}}


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[mdn-linter] reported by reviewdog 🐶

Suggested change

cos18
cos18 reviewed Oct 22, 2023
View reviewed changes
Copy link
Collaborator

@cos18 cos18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

안녕하세요. 첫 기여 해주셔서 감사합니다 :)

ko locale 규칙에 의해 가능하면 문서 전체의 원문 동기화 PR만 merge를 진행중에 있습니다. 이번 문서에서는 제가 원문과 비교해 없는 부분을 추가해 번역했습니다. 이후 기여시에 참고 부탁드립니다! 혹시 추가된 내용에 대해 궁금한 점이 있으시면 코멘트 달아주시고, 문제없으시다면 코멘트 달아주시면 머지 하겠습니다.

cos18
cos18 reviewed Oct 22, 2023
View reviewed changes
files/ko/web/api/canvas_api/tutorial/applying_styles_and_colors/index.md
Comment on lines +4 to +5
l10n:
sourceCommit: 6e0d822711793e8672d2ebfeea779890525f7529
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

추가로, 메타 데이타 태그가 없는 PR의 경우 이를 추가하도록 요청드리고 있습니다. 다음 기여시 참고 부탁드립니다 :)

@coolengineer
Copy link
Contributor Author

리뷰해 주셔서 감사합니다. ko locale 규칙이 있다는 것을 몰랐습니다.
추가해 주신 부분 문제 없으며, 다음 기여에 참고하겠습니다.
감사합니다.

@cos18 cos18 self-requested a review October 23, 2023 03:07
cos18
cos18 approved these changes Oct 23, 2023
View reviewed changes
Copy link
Collaborator

@cos18 cos18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@cos18 cos18 merged commit f90d1ae into mdn:main Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@cos18 cos18 cos18 approved these changes

Assignees
No one assigned
Labels
l10n-ko Issues related to Korean content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coolengineer @cos18