Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ko] update translation to btoa method in Web API #16769

Merged
merged 2 commits into from
Feb 25, 2024

Conversation

ykss
Copy link
Contributor

@ykss ykss commented Oct 30, 2023

Description

기존 페이지의 소스 커밋 및 전체 번역 업데이트 입니다.

Motivation

Additional details

Related issues and pull requests

@ykss ykss requested a review from a team as a code owner October 30, 2023 12:59
@ykss ykss requested review from sunhpark42 and removed request for a team October 30, 2023 12:59
@github-actions github-actions bot added the l10n-ko Issues related to Korean content. label Oct 30, 2023
@ykss ykss force-pushed the update/btoa-method branch from 709e023 to b8ccb38 Compare October 30, 2023 13:01
@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2023

Preview URLs

Flaws (2)

URL: /ko/docs/Web/API/btoa
Title: btoa() 전역 함수
Flaw count: 2

  • macros:
    • /ko/docs/Web/API/DOMException does not exist but fell back to /en-US/docs/Web/API/DOMException
  • translation_differences:
    • Differences in the important macros (3 in common of 4 possible)
External URLs (1)

URL: /ko/docs/Web/API/btoa
Title: btoa() 전역 함수

(comment last updated: 2023-11-15 14:32:27)

Copy link
Contributor

@sunhpark42 sunhpark42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

안녕하세요 @ykss 님, 번역본 업데이트 감사합니다 :)
URLs -> URL 들 혹은 한국어 표현상 URL이라고 적어도 될 것 같아서, 리뷰 남겨두었습니다.
다른 부분은 수정할 것이 없어보이네용! 확인 한 번 부탁드립니다.

기여 감사합니다 :)

- [`core-js`](https://github.com/zloirock/core-js)[`btoa` 폴리필](https://github.com/zloirock/core-js#base64-utility-methods)
- [`data` URL](/ko/docs/Web/HTTP/Basics_of_HTTP/Data_URLs)
- [`core-js`](https://github.com/zloirock/core-js)에서 사용 가능한 [`btoa` 폴리필](https://github.com/zloirock/core-js#base64-utility-methods)
- [`data` URLs](/ko/docs/Web/HTTP/Basics_of_HTTP/Data_URLs)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

한국어 번역이라서, URLs -> URL들 로 번역하는 것은 어떨지 의견드려 봅니다

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 감사합니다! 피드백 주신 사항은 반영 완료했습니다

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

안녕하세요 수정사항 확인했습니다. 리뷰가 늦어 죄송합니다🙇‍♀️

@ykss ykss requested a review from sunhpark42 November 15, 2023 14:30
@sunhpark42
Copy link
Contributor

안녕하세요. 확인이 늦어져 죄송합니다. 기여 감사합니다~! 좋은하루되세요.

@sunhpark42 sunhpark42 merged commit 5644569 into mdn:main Feb 25, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-ko Issues related to Korean content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants