refactor(ci/pr-review): use workflow_call instead of workflow_run event
#16891
chore: remove path matches
As the `pr-test` workflow is now a required ci test. This should be triggered in any PRs.
- Loading branch information
commit 67988cd06c209277a7ef37e732a5e56008c850fd
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,10 +14,6 @@ on: | |
| pull_request_target: | ||
| branches: | ||
| - main | ||
|
|
||
| jobs: | ||
| tests: | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Slight differences here: https://www.diffchecker.com/bU2WdBmN/, you may want to grab the latest version from
mainas there were some bugfixes on "non-markdown only" changed files, e.g.:if: ${{ env.GIT_DIFF_CONTENT }} || ${{ env.GIT_DIFF_FILES }There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which reminds me that these workflows should probably (eventually) live in https://github.com/mdn/workflows as they will diverge over time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in d9b1071