Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[zh-cn]: add the translation of JavaScript code example style guideline #17007

Merged
merged 17 commits into from
Nov 22, 2023
Merged

[zh-cn]: add the translation of JavaScript code example style guideline #17007

merged 17 commits into from
Nov 22, 2023

Conversation

JasonLamv-t
Copy link
Member

@JasonLamv-t JasonLamv-t commented Nov 17, 2023 •
edited
Loading

Description

Same as the title.

Motivation

Ditto.

Additional details

None.

Related issues and pull requests

#11063

@JasonLamv-t JasonLamv-t requested a review from a team as a code owner November 17, 2023 15:03
@JasonLamv-t JasonLamv-t requested review from yin1999 and removed request for a team November 17, 2023 15:03
@JasonLamv-t JasonLamv-t marked this pull request as draft November 17, 2023 15:03
@github-actions github-actions bot added the l10n-zh Issues related to Chinese content. label Nov 17, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 17, 2023 •
edited
Loading

Preview URLs

Flaws (1)

URL: /zh-CN/docs/MDN/Writing_guidelines/Writing_style_guide/Code_style_guide/JavaScript
Title: JavaScript 代码示例编写指南
Flaw count: 1

  • macros:
    • /zh-CN/docs/Glossary/camel_case does not exist but fell back to /en-US/docs/Glossary/Camel_case
External URLs (2)

URL: /zh-CN/docs/MDN/Writing_guidelines/Writing_style_guide/Code_style_guide/JavaScript
Title: JavaScript 代码示例编写指南

(comment last updated: 2023-11-22 08:13:05)

@yin1999 yin1999 mentioned this pull request Nov 19, 2023
Closed
53 tasks
@JasonLamv-t JasonLamv-t marked this pull request as ready for review November 21, 2023 01:44
@yin1999 yin1999 changed the title [zh-CN]: Add translation of JavaScript code example style guideline [zh-cn]: add the translation of JavaScript code example style guideline Nov 21, 2023
JasonLamv-t
JasonLamv-t commented Nov 21, 2023
View reviewed changes
files/zh-cn/mdn/writing_guidelines/writing_style_guide/code_style_guide/javascript/index.md Outdated Show resolved Hide resolved
files/zh-cn/mdn/writing_guidelines/writing_style_guide/code_style_guide/javascript/index.md Outdated Show resolved Hide resolved
files/zh-cn/mdn/writing_guidelines/writing_style_guide/code_style_guide/javascript/index.md Outdated Show resolved Hide resolved
files/zh-cn/mdn/writing_guidelines/writing_style_guide/code_style_guide/javascript/index.md Outdated Show resolved Hide resolved
files/zh-cn/mdn/writing_guidelines/writing_style_guide/code_style_guide/javascript/index.md Outdated Show resolved Hide resolved
files/zh-cn/mdn/writing_guidelines/writing_style_guide/code_style_guide/javascript/index.md Outdated Show resolved Hide resolved
yin1999
yin1999 reviewed Nov 21, 2023
View reviewed changes
Copy link
Member

@yin1999 yin1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed to line 315. The first comment is used for self note, please ignore this for now

files/zh-cn/mdn/writing_guidelines/writing_style_guide/code_style_guide/javascript/index.md Outdated Show resolved Hide resolved
files/zh-cn/mdn/writing_guidelines/writing_style_guide/code_style_guide/javascript/index.md Outdated Show resolved Hide resolved
files/zh-cn/mdn/writing_guidelines/writing_style_guide/code_style_guide/javascript/index.md Outdated Show resolved Hide resolved
files/zh-cn/mdn/writing_guidelines/writing_style_guide/code_style_guide/javascript/index.md Outdated Show resolved Hide resolved
files/zh-cn/mdn/writing_guidelines/writing_style_guide/code_style_guide/javascript/index.md Outdated Show resolved Hide resolved
files/zh-cn/mdn/writing_guidelines/writing_style_guide/code_style_guide/javascript/index.md Outdated Show resolved Hide resolved
files/zh-cn/mdn/writing_guidelines/writing_style_guide/code_style_guide/javascript/index.md Outdated Show resolved Hide resolved
JasonLamv-t and others added 6 commits November 21, 2023 23:18
@JasonLamv-t @yin1999
Update files/zh-cn/mdn/writing_guidelines/writing_style_guide/code_st…
df9e065 
…yle_guide/javascript/index.md

Co-authored-by: A1lo <[email protected]>
@JasonLamv-t @yin1999
Update files/zh-cn/mdn/writing_guidelines/writing_style_guide/code_st…
fcdd495 
…yle_guide/javascript/index.md

Co-authored-by: A1lo <[email protected]>
@JasonLamv-t @yin1999
Update files/zh-cn/mdn/writing_guidelines/writing_style_guide/code_st…
99a876e 
…yle_guide/javascript/index.md

Co-authored-by: A1lo <[email protected]>
@JasonLamv-t @yin1999
Update files/zh-cn/mdn/writing_guidelines/writing_style_guide/code_st…
0feafc2 
…yle_guide/javascript/index.md

Co-authored-by: A1lo <[email protected]>
@JasonLamv-t @yin1999
Update files/zh-cn/mdn/writing_guidelines/writing_style_guide/code_st…
1249ab4 
…yle_guide/javascript/index.md

Co-authored-by: A1lo <[email protected]>
@JasonLamv-t @yin1999
Update files/zh-cn/mdn/writing_guidelines/writing_style_guide/code_st…
4eb995b 
…yle_guide/javascript/index.md

Co-authored-by: A1lo <[email protected]>
yin1999
yin1999 reviewed Nov 22, 2023
View reviewed changes
Copy link
Member

@yin1999 yin1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

finished review. Could you please translate the strings in examples where appropriate

files/zh-cn/mdn/writing_guidelines/writing_style_guide/code_style_guide/javascript/index.md Outdated Show resolved Hide resolved
files/zh-cn/mdn/writing_guidelines/writing_style_guide/code_style_guide/javascript/index.md Outdated Show resolved Hide resolved
files/zh-cn/mdn/writing_guidelines/writing_style_guide/code_style_guide/javascript/index.md Outdated Show resolved Hide resolved
files/zh-cn/mdn/writing_guidelines/writing_style_guide/code_style_guide/javascript/index.md Outdated Show resolved Hide resolved
files/zh-cn/mdn/writing_guidelines/writing_style_guide/code_style_guide/javascript/index.md Outdated Show resolved Hide resolved
files/zh-cn/mdn/writing_guidelines/writing_style_guide/code_style_guide/javascript/index.md Outdated Show resolved Hide resolved
files/zh-cn/mdn/writing_guidelines/writing_style_guide/code_style_guide/javascript/index.md Outdated Show resolved Hide resolved
files/zh-cn/mdn/writing_guidelines/writing_style_guide/code_style_guide/javascript/index.md Outdated Show resolved Hide resolved
files/zh-cn/mdn/writing_guidelines/writing_style_guide/code_style_guide/javascript/index.md Outdated Show resolved Hide resolved
files/zh-cn/mdn/writing_guidelines/writing_style_guide/code_style_guide/javascript/index.md Outdated Show resolved Hide resolved
@JasonLamv-t
Copy link
Member Author

finished review. Could you please translate the strings in examples where appropriate

I have translated some strings in the code examples.

yin1999
yin1999 approved these changes Nov 22, 2023
View reviewed changes
Copy link
Member

@yin1999 yin1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JasonLamv-t ❤️

@yin1999 yin1999 merged commit fbfc64f into mdn:main Nov 22, 2023
7 checks passed
@JasonLamv-t JasonLamv-t deleted the write-guideline-js branch November 22, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yin1999 yin1999 yin1999 approved these changes

Assignees
No one assigned
Labels
l10n-zh Issues related to Chinese content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JasonLamv-t @yin1999