Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[zh-cn] Update 'working with the history api' #17063

Merged
merged 2 commits into from
Nov 23, 2023
Merged

[zh-cn] Update 'working with the history api' #17063

merged 2 commits into from
Nov 23, 2023

Conversation

jasonren0403
Copy link
Contributor

Description

reflect history API rewrite changes from upstream (mdn/content#30354)

Motivation

Additional details

Related issues and pull requests

@jasonren0403 jasonren0403 requested a review from a team as a code owner November 22, 2023 02:36
@jasonren0403 jasonren0403 requested review from t7yang and removed request for a team November 22, 2023 02:36
@github-actions github-actions bot added the l10n-zh Issues related to Chinese content. label Nov 22, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 22, 2023 •
edited
Loading

Preview URLs

Flaws (1)

URL: /zh-CN/docs/Web/API/History_API/Working_with_the_History_API
Title: 使用历史记录 API
Flaw count: 1

  • macros:
    • /zh-CN/docs/Web/API/PopStateEvent/state does not exist but fell back to /en-US/docs/Web/API/PopStateEvent/state
External URLs (1)

URL: /zh-CN/docs/Web/API/History_API/Working_with_the_History_API
Title: 使用历史记录 API

(comment last updated: 2023-11-23 03:45:34)

yin1999
yin1999 reviewed Nov 23, 2023
View reviewed changes
Copy link
Member

@yin1999 yin1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. This page once introduced me to the history API, now it's time to update it.

Let's fix some nits before merging :)

files/zh-cn/web/api/history_api/working_with_the_history_api/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/api/history_api/working_with_the_history_api/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/api/history_api/working_with_the_history_api/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/api/history_api/working_with_the_history_api/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/api/history_api/working_with_the_history_api/index.md Outdated Show resolved Hide resolved
@jasonren0403 jasonren0403 requested a review from yin1999 November 23, 2023 03:43
yin1999
yin1999 approved these changes Nov 23, 2023
View reviewed changes
Copy link
Member

@yin1999 yin1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jasonren0403

@yin1999 yin1999 merged commit 3a2f215 into main Nov 23, 2023
8 checks passed
@yin1999 yin1999 deleted the history-api-update branch November 23, 2023 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yin1999 yin1999 yin1999 approved these changes

@t7yang t7yang Awaiting requested review from t7yang t7yang is a code owner automatically assigned from mdn/yari-content-zh

Assignees
No one assigned
Labels
l10n-zh Issues related to Chinese content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jasonren0403 @yin1999