Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove localhost links #17087

Merged
merged 1 commit into from
Nov 28, 2023
Merged

chore: remove localhost links #17087

merged 1 commit into from
Nov 28, 2023

Conversation

yin1999
Copy link
Member

@yin1999 yin1999 commented Nov 24, 2023

Description

remove localhost links

@yin1999 yin1999 requested review from a team as code owners November 24, 2023 06:38
@yin1999 yin1999 requested review from yanaklose, pje1740 and mfuji09 and removed request for a team November 24, 2023 06:38
@github-actions github-actions bot added l10n-ja Issues related to Japanese content. l10n-ru Issues related to Russian content. l10n-ko Issues related to Korean content. system Infrastructure and configuration for the project labels Nov 24, 2023
Copy link
Contributor

Preview URLs

Flaws (148)

URL: /ko/docs/WebAssembly/Rust_to_Wasm
Title: Rust를 WebAssembly로 컴파일하기
Flaw count: 1

  • broken_links:
    • Is currently http:// but can become https://

URL: /ja/docs/Learn/Tools_and_testing/Cross_browser_testing/Your_own_automation_environment
Title: テスト自動化環境をセットアップする
Flaw count: 54

  • macros:
    • /ja/docs/Learn/MathML/First_steps does not exist but fell back to /en-US/docs/Learn/MathML/First_steps
    • /ja/docs/Learn/MathML/First_steps/Getting_started does not exist but fell back to /en-US/docs/Learn/MathML/First_steps/Getting_started
    • /ja/docs/Learn/MathML/First_steps/Text_containers does not exist but fell back to /en-US/docs/Learn/MathML/First_steps/Text_containers
    • /ja/docs/Learn/MathML/First_steps/Fractions_and_roots does not exist but fell back to /en-US/docs/Learn/MathML/First_steps/Fractions_and_roots
    • /ja/docs/Learn/MathML/First_steps/Scripts does not exist but fell back to /en-US/docs/Learn/MathML/First_steps/Scripts
    • and 46 more flaws omitted
  • broken_links:
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • Is currently http:// but can become https://

URL: /ru/docs/Learn/Server-side/Express_Nodejs/routes
Title: Учебник Express часть 4: Маршруты и контроллеры
Flaw count: 93

  • macros:
    • /ru/docs/Learn/CSS/Building_blocks/Cascade_layers does not exist but fell back to /en-US/docs/Learn/CSS/Building_blocks/Cascade_layers
    • /ru/docs/Learn/CSS/Building_blocks/Organizing does not exist but fell back to /en-US/docs/Learn/CSS/Building_blocks/Organizing
    • /ru/docs/Learn/CSS/Building_blocks/Creating_fancy_letterheaded_paper does not exist but fell back to /en-US/docs/Learn/CSS/Building_blocks/Creating_fancy_letterheaded_paper
    • /ru/docs/Learn/CSS/Building_blocks/A_cool_looking_box does not exist but fell back to /en-US/docs/Learn/CSS/Building_blocks/A_cool_looking_box
    • /ru/docs/Learn/CSS/CSS_layout/Media_queries does not exist but fell back to /en-US/docs/Learn/CSS/CSS_layout/Media_queries
    • and 82 more flaws omitted
  • broken_links:
    • Anchor not lowercase
    • Anchor not lowercase
    • Anchor not lowercase
    • Can't resolve /ru/docs/Web/JavaScript/Guide/Regular_Expressions
    • Link points to the page it's already on
    • and 1 more flaws omitted

Copy link
Collaborator

@mfuji09 mfuji09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with you for the ja article. Thank you!

Copy link
Member

@sashasushko sashasushko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve for Ru. Thanks 🤝

Copy link
Collaborator

@pje1740 pje1740 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@yin1999 yin1999 merged commit ebcf91a into mdn:main Nov 28, 2023
7 of 8 checks passed
@yin1999 yin1999 deleted the local branch November 28, 2023 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-ja Issues related to Japanese content. l10n-ko Issues related to Korean content. l10n-ru Issues related to Russian content. system Infrastructure and configuration for the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants