Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[es] remove obsolete orphaned/Web/API/Canvas_API/A_basic_ray-caster #17169

Conversation

leon-win
Copy link
Member

Description

This PR removes obsolete orphaned/Web/API/Canvas_API/A_basic_ray-caster page in es locale.

Related issues and pull requests

Relates to mdn/content#17352

@leon-win leon-win requested a review from a team as a code owner November 28, 2023 20:49
@leon-win leon-win requested review from JuanVqz and removed request for a team November 28, 2023 20:49
@github-actions github-actions bot added the l10n-es Issues related to Spanish content. label Nov 28, 2023
Copy link
Member

@JuanVqz JuanVqz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gracias por contribuir!

@JuanVqz JuanVqz requested a review from Graywolf9 November 28, 2023 21:17
Copy link
Contributor

@Graywolf9 Graywolf9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much! It seems to have some mentions too

@leon-win
Copy link
Member Author

Thank you so much! It seems to have some mentions too

Something needs to be improved?

@JuanVqz
Copy link
Member

JuanVqz commented Nov 29, 2023

Thank you so much! It seems to have some mentions too

Something needs to be improved?

I think what @Graywolf9 means is that there are some pages that still have the ray-caster word, I searched for it and found those:

@Graywolf9
Copy link
Contributor

Yeah, sorry, there are some mentions to the removed page

Copy link
Contributor

Preview URLs

Flaws (28)

URL: /es/docs/Web/API/Canvas_API
Title: API Canvas
Flaw count: 22

  • macros:
    • /es/docs/Web/API/CanvasGradient does not exist but fell back to /en-US/docs/Web/API/CanvasGradient
    • /es/docs/Web/API/CanvasPattern does not exist but fell back to /en-US/docs/Web/API/CanvasPattern
    • /es/docs/Web/API/ImageData does not exist but fell back to /en-US/docs/Web/API/ImageData
    • /es/docs/Web/API/RenderingContext does not exist
    • /es/docs/Web/API/TextMetrics does not exist but fell back to /en-US/docs/Web/API/TextMetrics
    • and 3 more flaws omitted
  • broken_links:
    • Can't resolve /es/docs/HTML/HTML5
    • Can't resolve /es/docs/Web/WebGL
    • Can't resolve /es/docs/Web/WebGL
    • Can't resolve /es/Add-ons/Code_snippets/Canvas
    • Can't resolve /es/docs/Web/API/Canvas_API/Drawing_DOM_objects_into_a_canvas
    • and 8 more flaws omitted
  • translation_differences:
    • Differences in the important macros (2 in common of 5 possible)

URL: /es/docs/Web/API/Canvas_API/Tutorial/Basic_animations
Title: Animaciones básicas
Flaw count: 6

  • macros:
    • /es/docs/Web/API/Window/setInterval does not exist but fell back to /en-US/docs/Web/API/setInterval
    • /es/docs/Web/API/Window/setTimeout does not exist but fell back to /en-US/docs/Web/API/setTimeout
    • /es/docs/Web/API/WindowTimers/setInterval redirects to /es/docs/Web/API/setInterval
    • /es/docs/Web/API/WindowTimers/setTimeout redirects to /es/docs/Web/API/setTimeout
    • wrong xref macro used (consider changing which macro you use)
  • translation_differences:
    • Differences in the important macros (1 in common of 8 possible)
External URLs (19)

URL: /es/docs/Web/API/Canvas_API
Title: API Canvas


URL: /es/docs/Web/API/Canvas_API/Tutorial/Basic_animations
Title: Animaciones básicas

@leon-win
Copy link
Member Author

Thank you so much! It seems to have some mentions too

Something needs to be improved?

I think what @Graywolf9 means is that there are some pages that still have the ray-caster word, I searched for it and found those:

* [ ]  ./files/es/web/api/canvas_api/index.md
  99:- [Demo: Un laberinto básico](/es/docs/Web/API/Canvas_API/A_basic_ray-caster)

* [ ]  ./files/es/web/api/canvas_api/tutorial/basic_animations/index.md
  327:- [Un ray-caster básico](/es/docs/Web/API/Canvas_API/A_basic_ray-caster)

Oh, my mistake! I didn't search along the path from the redirects((
Thank you for your attention!

Updated PR 👌
I removed these links, they are not in the en-us version either

@JuanVqz JuanVqz requested a review from Graywolf9 November 30, 2023 00:26
Copy link
Contributor

@Graywolf9 Graywolf9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for all your help!

@Graywolf9 Graywolf9 merged commit cb50f9e into mdn:main Nov 30, 2023
8 checks passed
@leon-win leon-win deleted the remove/es-orphaned-web-api-canvas-api-a-basic-ray-caster branch November 30, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-es Issues related to Spanish content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants