Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zh-cn: init translation of svelte components #17501

Merged
merged 8 commits into from
Dec 24, 2023

Conversation

hanyujie2002
Copy link
Contributor

Description

Same as title

Motivation

Ditto

Additional details

None

Related issues and pull requests

Relates to #16965

@hanyujie2002 hanyujie2002 requested a review from a team as a code owner December 17, 2023 12:47
@hanyujie2002 hanyujie2002 requested review from t7yang and removed request for a team December 17, 2023 12:47
@github-actions github-actions bot added the l10n-zh Issues related to Chinese content. label Dec 17, 2023
Copy link
Contributor

github-actions bot commented Dec 17, 2023

Preview URLs

Flaws (21)

URL: /zh-CN/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/Svelte_components
Title: 将我们的 Svelte 应用组件化
Flaw count: 21

  • macros:
    • /zh-CN/docs/Learn/Tools_and_testing/Understanding_client-side_tools/Deployment does not exist but fell back to /en-US/docs/Learn/Tools_and_testing/Understanding_client-side_tools/Deployment
    • /zh-CN/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_interactivity_events_state does not exist but fell back to /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_interactivity_events_state
    • /zh-CN/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_interactivity_filtering_conditional_rendering does not exist but fell back to /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_interactivity_filtering_conditional_rendering
    • /zh-CN/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_accessibility does not exist but fell back to /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_accessibility
    • /zh-CN/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_resources does not exist but fell back to /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_resources
    • and 16 more flaws omitted
External URLs (6)

URL: /zh-CN/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/Svelte_components
Title: 将我们的 Svelte 应用组件化

(comment last updated: 2023-12-24 05:29:09)

@yin1999 yin1999 requested review from yin1999 and removed request for t7yang December 18, 2023 08:36

这没有硬性规定。有些人更喜欢直观的方法,开始查看标记并在每个似乎具有自己逻辑的组件和子组件周围画框。

其他人应用同样用于决定是否创建新函数或对象的技术。其中一种技术是单一职责原则——也就是说,一个组件理想情况下只做一件事。如果它变得越来越庞大,应该将其拆分为更小的子组件。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
其他人应用同样用于决定是否创建新函数或对象的技术。其中一种技术是单一职责原则——也就是说,一个组件理想情况下只做一件事。如果它变得越来越庞大,应该将其拆分为更小的子组件。
其他人应使用同样的技术来决定是否创建新函数或对象。其中一种技术是单一职责原则——也就是说,一个组件理想情况下只做一件事。如果它变得越来越庞大,应该将其拆分为更小的子组件。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, but I can't agree with this recommendation. The original content is "Other people apply the same techniques used for deciding if you should create a new function or object." In my opinion, the "其他人应使用同样的技术来决定是否创建新函数或对象" seems to be more suitable if it is in the article introducing how to create new function or object. @yin1999

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about "其他人借鉴了一些用于创建新函数或对象的技术。"?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍


这没有硬性规定。有些人更喜欢直观的方法,开始查看标记并在每个似乎具有自己逻辑的组件和子组件周围画框。

其他人应用同样用于决定是否创建新函数或对象的技术。其中一种技术是单一职责原则——也就是说,一个组件理想情况下只做一件事。如果它变得越来越庞大,应该将其拆分为更小的子组件。
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, but I can't agree with this recommendation. The original content is "Other people apply the same techniques used for deciding if you should create a new function or object." In my opinion, the "其他人应使用同样的技术来决定是否创建新函数或对象" seems to be more suitable if it is in the article introducing how to create new function or object. @yin1999

@hanyujie2002 hanyujie2002 requested a review from yin1999 December 20, 2023 09:29
@yin1999
Copy link
Member

yin1999 commented Dec 20, 2023

One more fix, update the broken links to svelte, please check: mdn/content#31143.

Copy link
Member

@yin1999 yin1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @hanyujie2002 👍

@yin1999 yin1999 merged commit cb4d2ab into mdn:main Dec 24, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-zh Issues related to Chinese content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants