Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a code block style #17703

Merged
merged 2 commits into from
Jan 3, 2024
Merged

Fix a code block style #17703

merged 2 commits into from
Jan 3, 2024

Conversation

Frostbite-time
Copy link
Contributor

change plain to css

Description

Fixed an issue where the style of a Chinese translated code example was different from the English version

Motivation

Fixing this will make this content show the correct syntax highlighting

Additional details

Related issues and pull requests

Fixes #17696

@Frostbite-time
fix code block style
837f20c 
change plain to css
@Frostbite-time Frostbite-time requested a review from a team as a code owner January 3, 2024 14:10
@Frostbite-time Frostbite-time requested review from yin1999 and removed request for a team January 3, 2024 14:10
@github-actions github-actions bot added the l10n-zh Issues related to Chinese content. label Jan 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 3, 2024 •
edited
Loading

Preview URLs

Flaws (25)

URL: /zh-CN/docs/Learn/CSS/Building_blocks/Styling_tables
Title: 样式化表格
Flaw count: 25

  • macros:
    • /zh-CN/docs/Learn/Tools_and_testing/Understanding_client-side_tools/Deployment does not exist but fell back to /en-US/docs/Learn/Tools_and_testing/Understanding_client-side_tools/Deployment
    • /zh-CN/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_interactivity_events_state does not exist but fell back to /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_interactivity_events_state
    • /zh-CN/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_interactivity_filtering_conditional_rendering does not exist but fell back to /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_interactivity_filtering_conditional_rendering
    • /zh-CN/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_accessibility does not exist but fell back to /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_accessibility
    • /zh-CN/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_resources does not exist but fell back to /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_resources
    • and 18 more flaws omitted
  • broken_links:
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://

(comment last updated: 2024-01-03 14:18:49)

yin1999
yin1999 approved these changes Jan 3, 2024
View reviewed changes
Copy link
Member

@yin1999 yin1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Frostbite-time. I've pushed a commit to format the code block and it's ready to merge now.

Welcome to the community 🎉

@yin1999 yin1999 merged commit d1f2add into mdn:main Jan 3, 2024
7 checks passed
@Frostbite-time
Copy link
Contributor Author

@yin1999 Thanks for the review, glad to contribute here!

mfuji09 pushed a commit to mfuji09/MDN-translated-content that referenced this pull request Jan 4, 2024
@Frostbite-time @mfuji09
Fix a code block style (mdn#17703)
35b77fc
mfuji09 pushed a commit to mfuji09/MDN-translated-content that referenced this pull request Jan 4, 2024
@Frostbite-time @mfuji09
Fix a code block style (mdn#17703)
f7b4ebc
mfuji09 pushed a commit to mfuji09/MDN-translated-content that referenced this pull request Jan 4, 2024
@Frostbite-time @mfuji09
Fix a code block style (mdn#17703)
915fa1e
mfuji09 pushed a commit to mfuji09/MDN-translated-content that referenced this pull request Jan 4, 2024
@Frostbite-time @mfuji09
Fix a code block style (mdn#17703)
e52743e
mfuji09 pushed a commit to mfuji09/MDN-translated-content that referenced this pull request Jan 4, 2024
@Frostbite-time @mfuji09
Fix a code block style (mdn#17703)
9f2f433
mfuji09 pushed a commit to mfuji09/MDN-translated-content that referenced this pull request Jan 4, 2024
@Frostbite-time @mfuji09
Fix a code block style (mdn#17703)
853ca81
mfuji09 pushed a commit to mfuji09/MDN-translated-content that referenced this pull request Jan 4, 2024
@Frostbite-time @mfuji09
Fix a code block style (mdn#17703)
ce91c0d
mfuji09 pushed a commit to mfuji09/MDN-translated-content that referenced this pull request Jan 4, 2024
@Frostbite-time @mfuji09
Fix a code block style (mdn#17703)
c6ea5fa
mfuji09 pushed a commit to mfuji09/MDN-translated-content that referenced this pull request Jan 4, 2024
@Frostbite-time @mfuji09
Fix a code block style (mdn#17703)
59dd2e3
mfuji09 pushed a commit to mfuji09/MDN-translated-content that referenced this pull request Jan 4, 2024
@Frostbite-time @mfuji09
Fix a code block style (mdn#17703)
d85fa24
mfuji09 pushed a commit to mfuji09/MDN-translated-content that referenced this pull request Jan 4, 2024
@Frostbite-time @mfuji09
Fix a code block style (mdn#17703)
6c8cf20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yin1999 yin1999 yin1999 approved these changes

Assignees
No one assigned
Labels
l10n-zh Issues related to Chinese content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

zh-cn: 一个代码示例没有应用正确的样式
2 participants
@Frostbite-time @yin1999