Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ko: fix markdown tables #17887

Merged
merged 1 commit into from
Jan 16, 2024
Merged

ko: fix markdown tables #17887

merged 1 commit into from
Jan 16, 2024

Conversation

yin1999
Copy link
Member

@yin1999 yin1999 commented Jan 13, 2024

Description

fix markdown tables

Related issues and pull requests

prepare for: #17875

@yin1999 yin1999 requested a review from a team as a code owner January 13, 2024 12:36
@yin1999 yin1999 requested review from pje1740 and removed request for a team January 13, 2024 12:36
@github-actions github-actions bot added the l10n-ko Issues related to Korean content. label Jan 13, 2024
@@ -128,7 +128,7 @@
| Rendering | 렌더링 | |
| Section | 구획 | |
| Statement | 명령문 또는 문 | |
| short-circuit |
| short-circuit | | |
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the translation of short-circuit is missing, feel free to fix this

Copy link
Contributor

Preview URLs

Flaws (67)

URL: /ko/docs/Web/API/TreeWalker
Title: TreeWalker
Flaw count: 36

  • macros:
    • /ko/docs/Web/API/TreeWalker/root does not exist but fell back to /en-US/docs/Web/API/TreeWalker/root
    • /ko/docs/Web/API/Node does not exist but fell back to /en-US/docs/Web/API/Node
    • /ko/docs/Web/API/TreeWalker/whatToShow does not exist but fell back to /en-US/docs/Web/API/TreeWalker/whatToShow
    • /ko/docs/Web/API/Node does not exist but fell back to /en-US/docs/Web/API/Node
    • /ko/docs/Web/API/CDATASection does not exist but fell back to /en-US/docs/Web/API/CDATASection
    • and 31 more flaws omitted

URL: /ko/docs/Web/API/DOMParser
Title: DOMParser
Flaw count: 15

  • macros:
    • /ko/docs/Web/API/XMLHttpRequest/response does not exist but fell back to /en-US/docs/Web/API/XMLHttpRequest/response
    • /ko/docs/Web/API/XMLSerializer does not exist but fell back to /en-US/docs/Web/API/XMLSerializer
    • /ko/docs/Web/API/DOMParser/parseFromString does not exist but fell back to /en-US/docs/Web/API/DOMParser/parseFromString
    • /ko/docs/Web/API/XMLDocument does not exist but fell back to /en-US/docs/Web/API/XMLDocument
    • wrong xref macro used (consider changing which macro you use)
    • and 8 more flaws omitted
  • broken_links:
    • Anchor not lowercase
    • Can use the English (en-US) link as a fallback

URL: /ko/docs/Web/API/Document/createTreeWalker
Title: Document.createTreeWalker()
Flaw count: 16

  • macros:
    • /ko/docs/Web/API/Node does not exist but fell back to /en-US/docs/Web/API/Node
    • /ko/docs/Web/API/CDATASection does not exist but fell back to /en-US/docs/Web/API/CDATASection
    • /ko/docs/Web/API/Element does not exist but fell back to /en-US/docs/Web/API/Element
    • /ko/docs/Web/API/Entity does not exist
    • /ko/docs/Web/API/Entity does not exist
    • and 9 more flaws omitted
  • broken_links:
    • Is currently http:// but can become https://
  • translation_differences:
    • Differences in the important macros (3 in common of 5 possible)

@yin1999
Copy link
Member Author

yin1999 commented Jan 16, 2024

@mdn/yari-content-ko Is there any one who can handle this? This blocks the infrastructure PRs.

@wisedog wisedog self-requested a review January 16, 2024 04:02
Copy link
Contributor

@wisedog wisedog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for late.

@wisedog wisedog merged commit 17af13e into mdn:main Jan 16, 2024
6 checks passed
@yin1999 yin1999 deleted the fix-tables-ko branch January 16, 2024 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-ko Issues related to Korean content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants