-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sync-translated-content): gather releated upstream commits #18427
Conversation
99d9f6c
to
e449f85
Compare
ping @OnkarRuikar, @bsmth for a review :) |
Co-authored-by: Onkar Ruikar <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit
For testing all the changes so far is it possible to do following in your forks main branch?
Re-trigger the workflows on GitHub. This gives us more commit URLs to test. To bring back the fork to normal in local as well as on github:
|
Co-authored-by: Onkar Ruikar <[email protected]>
Done in main branch, see workflow run: https://github.com/yin1999/translated-content/actions/runs/8182413701 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yin1999#41 looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! Looks good! 👍🏻
Thank you @OnkarRuikar, @bsmth. I'm going to merge this shortly and have it a test in this repo after 🚢 |
It works well, see workflow run: https://github.com/mdn/translated-content/actions/runs/8187433241 |
…18427) Co-authored-by: Onkar Ruikar <[email protected]>
Description
gather releated upstream commits
Tested in my fork, check branch: https://github.com/yin1999/translated-content/tree/test-gather-urls
workflow run: https://github.com/yin1999/translated-content/actions/runs/8182413701
screenshot:
Related issues and pull requests
#9199 (comment)