Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(ci/pr-lint): specify lock file paths to reduce the search time #19898

Merged
merged 1 commit into from
May 1, 2024

Conversation

yin1999
Copy link
Member

@yin1999 yin1999 commented Apr 30, 2024

Description

Syntax: https://github.com/actions/setup-node/blob/main/docs/advanced-usage.md#caching-packages-data

The setup-node we used here will consume more time than the one in content significantly.

Test

Workflow run in my fork:

@github-actions github-actions bot added the system Infrastructure and configuration for the project label Apr 30, 2024
@yin1999 yin1999 marked this pull request as ready for review April 30, 2024 10:10
@yin1999 yin1999 requested a review from a team as a code owner April 30, 2024 10:10
@yin1999
Copy link
Member Author

yin1999 commented May 1, 2024

Thank you @caugner. Let's have a try on this :)


Append:

The step runs much faster than before, see:

It takes 6 seconds to setup the node runtime. And the cache-key is the same as before

image

@yin1999 yin1999 merged commit 32cbb37 into main May 1, 2024
7 of 8 checks passed
@yin1999 yin1999 deleted the yin1999-patch-1 branch May 1, 2024 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
system Infrastructure and configuration for the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants