Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[zh-cn]: create the translation of api.HTMLMediaElement.setSinkId() method #21687

Merged
merged 4 commits into from
Jul 29, 2024
Merged

[zh-cn]: create the translation of api.HTMLMediaElement.setSinkId() method #21687

merged 4 commits into from
Jul 29, 2024

Conversation

tianyeeT
Copy link
Contributor

#20744 (comment)

Description

Motivation

Additional details

Related issues and pull requests

@tianyeeT tianyeeT requested a review from a team as a code owner June 16, 2024 13:03
@tianyeeT tianyeeT requested review from t7yang and removed request for a team June 16, 2024 13:03
@github-actions github-actions bot added the l10n-zh Issues related to Chinese content. label Jun 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 16, 2024 •
edited
Loading

Preview URLs

Flaws (4)

URL: /zh-CN/docs/Web/API/HTMLMediaElement/setSinkId
Title: HTMLMediaElement：setSinkId() 方法
Flaw count: 4

  • macros:
    • /zh-CN/docs/Web/API/MediaDeviceInfo/deviceId does not exist but fell back to /en-US/docs/Web/API/MediaDeviceInfo/deviceId
    • /zh-CN/docs/Web/API/MediaDevices/selectAudioOutput does not exist but fell back to /en-US/docs/Web/API/MediaDevices/selectAudioOutput
    • /zh-CN/docs/Web/API/MediaDevices/selectAudioOutput does not exist but fell back to /en-US/docs/Web/API/MediaDevices/selectAudioOutput
    • /zh-CN/docs/Web/API/HTMLMediaElement/sinkId does not exist but fell back to /en-US/docs/Web/API/HTMLMediaElement/sinkId

(comment last updated: 2024-07-29 04:57:49)

yin1999
yin1999 requested changes Jun 16, 2024
View reviewed changes
Copy link
Member

@yin1999 yin1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

其他的两个 PR 也有类似的问题，请修改

files/zh-cn/web/api/htmlmediaelement/setsinkid/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/api/htmlmediaelement/setsinkid/index.md Outdated Show resolved Hide resolved
@yin1999 yin1999 mentioned this pull request Jun 16, 2024
Closed
@yin1999
Copy link
Member

yin1999 commented Jun 16, 2024 •
edited
Loading

Blocked by mdn/content#34088

@yin1999 yin1999 marked this pull request as draft June 16, 2024 13:42
@yin1999 yin1999 added the needs content update Needs update to the content to support this change. label Jun 16, 2024
skyclouds2001
skyclouds2001 reviewed Jul 20, 2024
View reviewed changes
Copy link
Contributor

@skyclouds2001 skyclouds2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mdn/content#34088 has been merged

@yin1999 yin1999 removed the needs content update Needs update to the content to support this change. label Jul 29, 2024
@yin1999 yin1999 marked this pull request as ready for review July 29, 2024 04:42
@yin1999 yin1999 merged commit a73fd54 into mdn:main Jul 29, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skyclouds2001 skyclouds2001 skyclouds2001 left review comments

@yin1999 yin1999 yin1999 approved these changes

@t7yang t7yang Awaiting requested review from t7yang t7yang is a code owner automatically assigned from mdn/yari-content-zh

Assignees
No one assigned
Labels
l10n-zh Issues related to Chinese content.
Projects
MDN translated-content l10n-zh
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tianyeeT @yin1999 @skyclouds2001