Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ko] logical properties - sizing 신규 번역 #21968

Merged
merged 2 commits into from
Jul 30, 2024

Conversation

givvemee
Copy link
Contributor

Description

기존에 한국어로 존재하지 않던 문서 Logical properties for sizing 를 번역합니다.

Motivation

Additional details

Related issues and pull requests

@givvemee givvemee requested a review from a team as a code owner June 27, 2024 00:50
@givvemee givvemee requested review from sunhpark42 and removed request for a team June 27, 2024 00:50
@github-actions github-actions bot added the l10n-ko Issues related to Korean content. label Jun 27, 2024
Copy link
Contributor

github-actions bot commented Jun 27, 2024

Preview URLs

Flaws (15)

URL: /ko/docs/Web/CSS/CSS_logical_properties_and_values/Sizing
Title: 크기 조절에 관한 논리적 속성
Flaw count: 15

  • macros:
    • /ko/docs/Web/CSS/inline-size does not exist but fell back to /en-US/docs/Web/CSS/inline-size
    • /ko/docs/Web/CSS/inline-size does not exist but fell back to /en-US/docs/Web/CSS/inline-size
    • /ko/docs/Web/CSS/inline-size does not exist but fell back to /en-US/docs/Web/CSS/inline-size
    • /ko/docs/Web/CSS/block-size does not exist but fell back to /en-US/docs/Web/CSS/block-size
    • /ko/docs/Web/CSS/min-inline-size does not exist but fell back to /en-US/docs/Web/CSS/min-inline-size
    • and 10 more flaws omitted

(comment last updated: 2024-07-30 00:52:59)

Copy link
Contributor

@sunhpark42 sunhpark42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

안녕하세요 @givvemee 님, 수정 필요한 부분이 있어 리뷰 남겼습니다.
확인 부탁드립니다 :)
감사합니다!


## 최소 너비와 최소 높이에 관한 예제

{{CSSxRef("min-width")}} 와 {{CSSxRef("min-height")}} 를 위한 매핑 {{CSSxRef("min-inline-size")}} 와 {{CSSxRef("min-block-size")}} 도 존재합니다. 이들은 `inline-size` 와 `block-size` 속성과 동일하게 동작하지만, 최소 크기가 아닌 고정된 크기를 설정합니다.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setting a minimum rather than a fixed size.라서 고정된 크기가 아닌 최소 크기를 설정합니다. 로 번역 되어야 할 것 같습니다.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

와악 ... 큰일날 뻔 했네요. 감사해요!

@@ -0,0 +1,57 @@
---
title: Logical properties for sizing
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

타이틀도 번역 부탁드려요!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sunhpark42 리뷰 감사합니다.

@givvemee givvemee requested review from sunhpark42 July 1, 2024 00:32
Copy link
Member

@hochan222 hochan222 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@givvemee 님 안녕하세요.

리뷰내용 아직 반영되지 않아 멘션드렸습니다.

감사합니다!

@givvemee
Copy link
Contributor Author

@hochan222 아이고... 이거 커밋을 안 했었네요. 감사해요!

@givvemee givvemee requested a review from hochan222 July 30, 2024 00:51
Copy link
Member

@hochan222 hochan222 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@hochan222 hochan222 merged commit 3f39212 into mdn:main Jul 30, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-ko Issues related to Korean content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants