Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ko] TypedArray.prototype.toString() 신규 번역 외 #22187

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

wisedog
Copy link
Contributor

@wisedog wisedog commented Jul 6, 2024

  • TypedArray.prototype.toString() 신규 번역
  • Array.prototype.toString() 최신화

- TypedArray.prototype.toString() 신규 번역
- Array.prototype.toString() 최신화
@wisedog wisedog requested a review from a team as a code owner July 6, 2024 07:56
@wisedog wisedog requested review from yechoi42 and removed request for a team July 6, 2024 07:56
@github-actions github-actions bot added the l10n-ko Issues related to Korean content. label Jul 6, 2024
Copy link
Contributor

github-actions bot commented Jul 6, 2024

Preview URLs

Flaws (1)

Note! 1 document with no flaws that don't need to be listed. 🎉

URL: /ko/docs/Web/JavaScript/Reference/Global_Objects/TypedArray/toString
Title: TypedArray.prototype.toString()
Flaw count: 1

  • macros:
    • /ko/docs/Web/JavaScript/Reference/Global_Objects/TypedArray/toLocaleString does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Global_Objects/TypedArray/toLocaleString

(comment last updated: 2024-08-01 23:09:00)

@wisedog
Copy link
Contributor Author

wisedog commented Aug 1, 2024

@1ilsang 죄송한데, 이 PR 리뷰 부탁드려도 될까요? 🥹

@1ilsang 1ilsang requested review from 1ilsang and removed request for yechoi42 August 1, 2024 05:23
Copy link
Member

@1ilsang 1ilsang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wisedog 님 안녕하세요. 기여해주셔서 감사합니다! 💯

몇 가지 코멘트 남겨두었습니다.

확인하시고 다시 리뷰 요청 부탁드리겠습니다. 🙇

질문이나 도움이 필요하시다면 언제든 멘션 부탁드리겠습니다.


```js
console.log(Array.prototype.toString.call({ join: () => 1 }));
// 1; a number
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// 1; a number
// 1; 숫자 타입

---

{{JSRef}}

**`toString()`** 메서드는 지정된 배열 및 그 요소를 나타내는 문자열을 반환합니다.
{{jsxref("Array")}} 인스턴스의 **`toString()`** 메서드는 지정된 배열 및 그 요소를 나타내는 문자열을 반환합니다.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{{jsxref("Array")}} 인스턴스의 **`toString()`** 메서드는 지정된 배열 및 그 요소를 나타내는 문자열을 반환합니다.
{{jsxref("Array")}} 인스턴스의 **`toString()`** 메서드는
지정된 배열 및 그 요소를 나타내는 문자열을 반환합니다.

줄 수는 원문과 동일하게 해주세요. 관련 논의는 여기에서 확인할 수 있습니다.

@wisedog wisedog requested a review from 1ilsang August 1, 2024 23:14
@1ilsang 1ilsang merged commit f86a252 into mdn:main Aug 2, 2024
7 checks passed
@wisedog wisedog deleted the js/typedarray-tostring branch August 2, 2024 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-ko Issues related to Korean content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants