Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ko] pushSubscription, pushSubscription.unsubscribe() 신규 번역 #22370

Merged
merged 3 commits into from
Jul 16, 2024
Merged

[ko] pushSubscription, pushSubscription.unsubscribe() 신규 번역 #22370

merged 3 commits into from
Jul 16, 2024

Conversation

etoile-j
Copy link
Contributor

Description

PUSH API의 pushSubscription, pushSubscription.unsubscribe() 문서를 신규 번역하였습니다.

@etoile-j etoile-j requested a review from a team as a code owner July 12, 2024 08:09
@etoile-j etoile-j requested review from 1ilsang and removed request for a team July 12, 2024 08:09
@github-actions github-actions bot added the l10n-ko Issues related to Korean content. label Jul 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 12, 2024 •
edited
Loading

Preview URLs

Flaws (8)

URL: /ko/docs/Web/API/PushSubscription
Title: PushSubscription
Flaw count: 7

  • macros:
    • /ko/docs/Web/API/PushSubscription/endpoint does not exist but fell back to /en-US/docs/Web/API/PushSubscription/endpoint
    • /ko/docs/Web/API/PushSubscription/expirationTime does not exist but fell back to /en-US/docs/Web/API/PushSubscription/expirationTime
    • /ko/docs/Web/API/DOMHighResTimeStamp does not exist but fell back to /en-US/docs/Web/API/DOMHighResTimeStamp
    • /ko/docs/Web/API/PushSubscription/options does not exist but fell back to /en-US/docs/Web/API/PushSubscription/options
    • /ko/docs/Web/API/PushSubscription/subscriptionId does not exist but fell back to /en-US/docs/Web/API/PushSubscription/subscriptionId
    • and 2 more flaws omitted

URL: /ko/docs/Web/API/PushSubscription/unsubscribe
Title: PushSubscription: unsubscribe() 메서드
Flaw count: 1

  • macros:
    • /ko/docs/Web/API/PushManager/getSubscription does not exist but fell back to /en-US/docs/Web/API/PushManager/getSubscription

(comment last updated: 2024-07-16 11:21:48)

1ilsang
1ilsang requested changes Jul 15, 2024
View reviewed changes
Copy link
Member

@1ilsang 1ilsang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@etoile-j 님 안녕하세요. 기여해주셔서 감사합니다! 💯

몇 가지 코멘트 남겨두었습니다.

확인하시고 다시 리뷰 요청 부탁드리겠습니다. 🙇

질문이나 도움이 필요하시다면 언제든 멘션 부탁드리겠습니다.

files/ko/web/api/pushsubscription/unsubscribe/index.md Outdated
Comment on lines 11 to 12
{{domxref("PushSubscription")}} 인터페이스의 `unsubscribe()` 메서드는
현재 구독이 성공적으로 구독 취소될 때 불리언 값으로 이행되는 {{jsxref("Promise")}}를 반환합니다.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{{domxref("PushSubscription")}} 인터페이스의 `unsubscribe()` 메서드는
현재 구독이 성공적으로 구독 취소될 때 불리언 값으로 이행되는 {{jsxref("Promise")}}를 반환합니다.
{{domxref("PushSubscription")}} 인터페이스의 `unsubscribe()` 메서드는
현재 구독이 성공적으로 구독 취소될 때 불리언 값으로 이행되는
{{jsxref("Promise")}}를 반환합니다.

줄 수는 원문과 동일하게 해주세요. 관련 논의는 여기에서 확인할 수 있습니다.

files/ko/web/api/pushsubscription/unsubscribe/index.md Outdated

### 반환 값

현재 구독이 성공적으로 구독 취소될 때 불리언 값으로 이행되는 {{jsxref("Promise")}}.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
현재 구독이 성공적으로 구독 취소될 때 불리언 값으로 이행되는 {{jsxref("Promise")}}.
현재 구독이 성공적으로 구독 취소될 때
불리언 값으로 이행되는 {{jsxref("Promise")}}.

줄 수는 원문과 동일하게 해주세요. 관련 논의는 여기에서 확인할 수 있습니다.

files/ko/web/api/pushsubscription/index.md Outdated
## 인스턴스 속성

- {{domxref("PushSubscription.endpoint")}} {{ReadOnlyInline}}
- : 푸시 구독과 연결된 엔드포인트가 포함된 문자열.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- : 푸시 구독과 연결된 엔드포인트가 포함된 문자열.
- : 푸시 구독과 관련된 엔드포인트가 포함된 문자열.

밑에서 associated를 "관련된"으로 사용하고 있으므로 통일시키는 것을 제안드립니다.

오타가 맞을까요? 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

네😅 수정하였습니다

@etoile-j
Copy link
Contributor Author

@1ilsang 안녕하세요. 말씀해 주신 사항들 수정하였습니다!
줄 수의 경우 원문이 제각각이라 자유롭게 해도 되는 줄..알았습니다 😅

1ilsang
1ilsang approved these changes Jul 16, 2024
View reviewed changes
Copy link
Member

@1ilsang 1ilsang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 고생하셨습니다. 💯

@1ilsang 1ilsang merged commit d8ff20c into mdn:main Jul 16, 2024
7 checks passed
@etoile-j etoile-j deleted the ko_pushSubscription branch July 18, 2024 06:00
@etoile-j etoile-j mentioned this pull request Aug 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1ilsang 1ilsang 1ilsang approved these changes

Assignees
No one assigned
Labels
l10n-ko Issues related to Korean content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@etoile-j @1ilsang