Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zh-CN: update Glossary/ATAG #22603

Merged
merged 4 commits into from
Jul 27, 2024
Merged

zh-CN: update Glossary/ATAG #22603

merged 4 commits into from
Jul 27, 2024

Conversation

PassionPenguin
Copy link
Contributor

No description provided.

@PassionPenguin PassionPenguin requested a review from a team as a code owner July 26, 2024 01:38
@PassionPenguin PassionPenguin requested review from jasonren0403 and removed request for a team July 26, 2024 01:38
@github-actions github-actions bot added the l10n-zh Issues related to Chinese content. label Jul 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 26, 2024 •
edited
Loading

Preview URLs

Flaws (1)

URL: /zh-CN/docs/Glossary/ATAG
Title: ATAG
Flaw count: 1

  • macros:
    • /zh-CN/docs/Glossary/UAAG does not exist but fell back to /en-US/docs/Glossary/UAAG

(comment last updated: 2024-07-26 09:08:38)

jasonren0403
jasonren0403 requested changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@jasonren0403 jasonren0403 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

请检查下所提交的文件（你似乎误删除了 attribute 的翻译）

@PassionPenguin
Copy link
Contributor Author

PassionPenguin commented Jul 26, 2024 •
edited
Loading

请检查下所提交的文件（你似乎误删除了 attribute 的翻译）

attribute是误添加到这儿的（see #22604

@yin1999
Copy link
Member

yin1999 commented Jul 26, 2024

不是这样撤销的，你这样会把文件删掉

@PassionPenguin
Copy link
Contributor Author

PassionPenguin commented Jul 26, 2024 •
edited
Loading

不是这样撤销的，你这样会把文件删掉

诶，我记得我是rollback了诶，应该是给搞错了（

对不起！！🧎

@yin1999 yin1999 requested a review from jasonren0403 July 26, 2024 09:07
@yin1999
Copy link
Member

yin1999 commented Jul 26, 2024

要撤销文件的修改，就只要保证，你新建的所有提交在合并以后，是没有特定文件的任何修改的（而不是删除这个文件）。所以最简单的方法就找到当前 PR 所基于的基础 commit，去复制对应文件的全部内容，覆盖提交一下。

jasonren0403
jasonren0403 approved these changes Jul 27, 2024
View reviewed changes
Copy link
Contributor

@jasonren0403 jasonren0403 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jasonren0403 jasonren0403 merged commit ad22884 into mdn:main Jul 27, 2024
7 checks passed
@PassionPenguin PassionPenguin deleted the patch-10 branch July 27, 2024 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonren0403 jasonren0403 jasonren0403 approved these changes

Assignees
No one assigned
Labels
l10n-zh Issues related to Chinese content.
Projects
MDN translated-content l10n-zh
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PassionPenguin @yin1999 @jasonren0403