Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ko: Convert noteblocks to GFM Alerts (part 5) #22762

Merged
merged 3 commits into from
Jul 30, 2024
Merged

ko: Convert noteblocks to GFM Alerts (part 5) #22762

merged 3 commits into from
Jul 30, 2024

Conversation

queengooborg
Copy link
Collaborator

@queengooborg queengooborg commented Jul 28, 2024

This PR converts the noteblocks for the Korean locale to GFM Alerts syntax, using a conversion script. This is part 5. Note: manual adjustments have also been made to correct some issues, including capitalization, syntax, duplicated keywords and more.

Note: the CI failure is due to existing flaws and is not related to the changes made in this PR.

This PR converts the noteblocks for the Korean locale to GFM Alerts syntax, using a [conversion script](https://github.com/queengooborg/mdn-toolkit/blob/main/upgrade-noteblock.js). This is part 5. Note: manual adjustments have also been made to correct some issues, including capitalization, syntax, duplicated keywords and more.
@queengooborg queengooborg requested a review from a team as a code owner July 28, 2024 20:40
@queengooborg queengooborg requested review from wisedog and removed request for a team July 28, 2024 20:40
@github-actions github-actions bot added the l10n-ko Issues related to Korean content. label Jul 28, 2024
@github-actions github-actions bot added the merge conflicts 🚧 This pull request has merge conflicts that must be resolved. label Jul 30, 2024
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot removed the merge conflicts 🚧 This pull request has merge conflicts that must be resolved. label Jul 30, 2024
@wisedog
Copy link
Contributor

wisedog commented Jul 30, 2024

Nice work, thank you. LGTM!

@wisedog wisedog merged commit 090ccaf into main Jul 30, 2024
7 of 8 checks passed
@wisedog wisedog deleted the gfm-alerts/ko/5 branch July 30, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-ko Issues related to Korean content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants