Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ko: Convert callouts to GFM Alerts style #22811

Merged
merged 2 commits into from
Jul 31, 2024
Merged

ko: Convert callouts to GFM Alerts style #22811

merged 2 commits into from
Jul 31, 2024

Conversation

queengooborg
Copy link
Collaborator

This PR converts the callouts throughout the Korean locale to the GFM Alerts style. In the process, it also fixes numerous formatting issues (misuse of headers).

@queengooborg queengooborg requested a review from a team as a code owner July 30, 2024 09:42
@queengooborg queengooborg requested review from sunhpark42 and removed request for a team July 30, 2024 09:42
@github-actions github-actions bot added the l10n-ko Issues related to Korean content. label Jul 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 30, 2024 •
edited
Loading

Preview URLs (10 pages)
Flaws (770)

URL: /ko/docs/Web/CSS
Title: CSS: Cascading Style Sheets
Flaw count: 15

  • broken_links:
    • Can't resolve /ko/docs/Learn/Front-end_web_developer
    • Can't resolve /ko/docs/Web/CSS/inheritance
    • Can't resolve /ko/docs/Web/CSS/CSS_Box_Model/Introduction_to_the_CSS_box_model
    • Can't resolve /ko/docs/Web/CSS/CSS_Box_Model/Mastering_margin_collapsing
    • Can't resolve /ko/docs/Web/CSS/CSS_Positioning/Understanding_z_index/The_stacking_context
    • and 10 more flaws omitted

URL: /ko/docs/Web/HTML
Title: HTML: Hypertext Markup Language
Flaw count: 32

  • macros:
    • /ko/docs/Learn/HTML/Introduction_to_HTML/Document_and_website_structure does not exist but fell back to /en-US/docs/Learn/HTML/Introduction_to_HTML/Document_and_website_structure
    • /ko/docs/Learn/HTML/Introduction_to_HTML/Debugging_HTML does not exist but fell back to /en-US/docs/Learn/HTML/Introduction_to_HTML/Debugging_HTML
    • /ko/docs/Learn/HTML/Multimedia_and_embedding/Video_and_audio_content does not exist but fell back to /en-US/docs/Learn/HTML/Multimedia_and_embedding/Video_and_audio_content
    • /ko/docs/Learn/HTML/Multimedia_and_embedding/Mozilla_splash_page does not exist but fell back to /en-US/docs/Learn/HTML/Multimedia_and_embedding/Mozilla_splash_page
    • /ko/docs/Web/HTML/Attributes/accept does not exist but fell back to /en-US/docs/Web/HTML/Attributes/accept
    • and 21 more flaws omitted
  • broken_links:
    • Can't resolve /ko/docs/Learn/Front-end_web_developer
    • Can't resolve /ko/docs/Web/HTML/Link_types/preload
    • Can't resolve /ko/docs/Web/HTML/Inline_elements
    • Can't resolve /ko/docs/Web/HTML/Block-level_elements
    • Can't resolve /ko/docs/Web/Guide/HTML/Content_categories
    • and 1 more flaws omitted

URL: /ko/docs/Web/JavaScript/Reference/Strict_mode
Title: Strict mode
Flaw count: 17

  • macros:
    • /ko/docs/Web/JavaScript/Guide/Using_classes does not exist but fell back to /en-US/docs/Web/JavaScript/Guide/Using_classes
    • /ko/docs/Web/JavaScript/Guide/Meta_programming does not exist but fell back to /en-US/docs/Web/JavaScript/Guide/Meta_programming
    • /ko/docs/Web/JavaScript/Reference/Lexical_grammar does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Lexical_grammar
    • /ko/docs/Web/JavaScript/Reference/Deprecated_and_obsolete_features does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Deprecated_and_obsolete_features
    • /ko/docs/Web/API/WindowTimers/setTimeout redirects to /ko/docs/Web/API/setTimeout
  • broken_links:
    • Is currently http:// but can become https://
    • Can't resolve /ko/docs/Web/JavaScript/Reference/Strict_mode/Transitioning_to_strict_mode
    • Is currently http:// but can become https://
    • Can't resolve /en-US/Web/JavaScript/Reference/Global_Objects/Function/call
    • Can't resolve /en-US/Web/JavaScript/Reference/Global_Objects/Function/apply
    • and 7 more flaws omitted

URL: /ko/docs/Learn
Title: Web 개발 학습하기
Flaw count: 101

  • macros:
    • /ko/docs/Learn/HTML/Introduction_to_HTML/Document_and_website_structure does not exist but fell back to /en-US/docs/Learn/HTML/Introduction_to_HTML/Document_and_website_structure
    • /ko/docs/Learn/HTML/Introduction_to_HTML/Debugging_HTML does not exist but fell back to /en-US/docs/Learn/HTML/Introduction_to_HTML/Debugging_HTML
    • /ko/docs/Learn/HTML/Multimedia_and_embedding/Video_and_audio_content does not exist but fell back to /en-US/docs/Learn/HTML/Multimedia_and_embedding/Video_and_audio_content
    • /ko/docs/Learn/HTML/Multimedia_and_embedding/Mozilla_splash_page does not exist but fell back to /en-US/docs/Learn/HTML/Multimedia_and_embedding/Mozilla_splash_page
    • /ko/docs/Learn/CSS/Building_blocks/Advanced_styling_effects does not exist but fell back to /en-US/docs/Learn/CSS/Building_blocks/Advanced_styling_effects
    • and 94 more flaws omitted
  • broken_links:
    • Can't resolve /ko/docs/Learn/Front-end_web_developer
    • Can't resolve /ko/docs/MDN/Contribute

URL: /ko/docs/Learn/HTML/Introduction_to_HTML
Title: HTML 소개
Flaw count: 100

  • macros:
    • /ko/docs/Learn/HTML/Introduction_to_HTML/Document_and_website_structure does not exist but fell back to /en-US/docs/Learn/HTML/Introduction_to_HTML/Document_and_website_structure
    • /ko/docs/Learn/HTML/Introduction_to_HTML/Debugging_HTML does not exist but fell back to /en-US/docs/Learn/HTML/Introduction_to_HTML/Debugging_HTML
    • /ko/docs/Learn/HTML/Multimedia_and_embedding/Video_and_audio_content does not exist but fell back to /en-US/docs/Learn/HTML/Multimedia_and_embedding/Video_and_audio_content
    • /ko/docs/Learn/HTML/Multimedia_and_embedding/Mozilla_splash_page does not exist but fell back to /en-US/docs/Learn/HTML/Multimedia_and_embedding/Mozilla_splash_page
    • /ko/docs/Learn/CSS/Building_blocks/Advanced_styling_effects does not exist but fell back to /en-US/docs/Learn/CSS/Building_blocks/Advanced_styling_effects
    • and 94 more flaws omitted
  • broken_links:
    • Can't resolve /ko/docs/Learn/Front-end_web_developer

URL: /ko/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks
Title: 클라이언트 사이드 JavaScript 프레임워크
Flaw count: 100

  • macros:
    • /ko/docs/Learn/HTML/Introduction_to_HTML/Document_and_website_structure does not exist but fell back to /en-US/docs/Learn/HTML/Introduction_to_HTML/Document_and_website_structure
    • /ko/docs/Learn/HTML/Introduction_to_HTML/Debugging_HTML does not exist but fell back to /en-US/docs/Learn/HTML/Introduction_to_HTML/Debugging_HTML
    • /ko/docs/Learn/HTML/Multimedia_and_embedding/Video_and_audio_content does not exist but fell back to /en-US/docs/Learn/HTML/Multimedia_and_embedding/Video_and_audio_content
    • /ko/docs/Learn/HTML/Multimedia_and_embedding/Mozilla_splash_page does not exist but fell back to /en-US/docs/Learn/HTML/Multimedia_and_embedding/Mozilla_splash_page
    • /ko/docs/Learn/CSS/Building_blocks/Advanced_styling_effects does not exist but fell back to /en-US/docs/Learn/CSS/Building_blocks/Advanced_styling_effects
    • and 94 more flaws omitted
  • broken_links:
    • Can't resolve /ko/docs/Learn/Front-end_web_developer

URL: /ko/docs/Learn/JavaScript/Building_blocks
Title: JavaScript 구성요소
Flaw count: 100

  • macros:
    • /ko/docs/Learn/HTML/Introduction_to_HTML/Document_and_website_structure does not exist but fell back to /en-US/docs/Learn/HTML/Introduction_to_HTML/Document_and_website_structure
    • /ko/docs/Learn/HTML/Introduction_to_HTML/Debugging_HTML does not exist but fell back to /en-US/docs/Learn/HTML/Introduction_to_HTML/Debugging_HTML
    • /ko/docs/Learn/HTML/Multimedia_and_embedding/Video_and_audio_content does not exist but fell back to /en-US/docs/Learn/HTML/Multimedia_and_embedding/Video_and_audio_content
    • /ko/docs/Learn/HTML/Multimedia_and_embedding/Mozilla_splash_page does not exist but fell back to /en-US/docs/Learn/HTML/Multimedia_and_embedding/Mozilla_splash_page
    • /ko/docs/Learn/CSS/Building_blocks/Advanced_styling_effects does not exist but fell back to /en-US/docs/Learn/CSS/Building_blocks/Advanced_styling_effects
    • and 94 more flaws omitted
  • broken_links:
    • Can't resolve /ko/docs/Learn/Front-end_web_developer

URL: /ko/docs/Learn/JavaScript/Asynchronous
Title: 비동기 JavaScript
Flaw count: 100

  • macros:
    • /ko/docs/Learn/HTML/Introduction_to_HTML/Document_and_website_structure does not exist but fell back to /en-US/docs/Learn/HTML/Introduction_to_HTML/Document_and_website_structure
    • /ko/docs/Learn/HTML/Introduction_to_HTML/Debugging_HTML does not exist but fell back to /en-US/docs/Learn/HTML/Introduction_to_HTML/Debugging_HTML
    • /ko/docs/Learn/HTML/Multimedia_and_embedding/Video_and_audio_content does not exist but fell back to /en-US/docs/Learn/HTML/Multimedia_and_embedding/Video_and_audio_content
    • /ko/docs/Learn/HTML/Multimedia_and_embedding/Mozilla_splash_page does not exist but fell back to /en-US/docs/Learn/HTML/Multimedia_and_embedding/Mozilla_splash_page
    • /ko/docs/Learn/CSS/Building_blocks/Advanced_styling_effects does not exist but fell back to /en-US/docs/Learn/CSS/Building_blocks/Advanced_styling_effects
    • and 94 more flaws omitted
  • broken_links:
    • Can't resolve /ko/docs/Learn/Front-end_web_developer

URL: /ko/docs/Learn/JavaScript/First_steps
Title: JavaScript 첫걸음
Flaw count: 101

  • macros:
    • /ko/docs/Learn/HTML/Introduction_to_HTML/Document_and_website_structure does not exist but fell back to /en-US/docs/Learn/HTML/Introduction_to_HTML/Document_and_website_structure
    • /ko/docs/Learn/HTML/Introduction_to_HTML/Debugging_HTML does not exist but fell back to /en-US/docs/Learn/HTML/Introduction_to_HTML/Debugging_HTML
    • /ko/docs/Learn/HTML/Multimedia_and_embedding/Video_and_audio_content does not exist but fell back to /en-US/docs/Learn/HTML/Multimedia_and_embedding/Video_and_audio_content
    • /ko/docs/Learn/HTML/Multimedia_and_embedding/Mozilla_splash_page does not exist but fell back to /en-US/docs/Learn/HTML/Multimedia_and_embedding/Mozilla_splash_page
    • /ko/docs/Learn/CSS/Building_blocks/Advanced_styling_effects does not exist but fell back to /en-US/docs/Learn/CSS/Building_blocks/Advanced_styling_effects
    • and 94 more flaws omitted
  • broken_links:
    • Can't resolve /ko/docs/Learn/Front-end_web_developer
    • Can't resolve /ko/docs/Learn/CSS/Introduction_to_CSS

URL: /ko/docs/Learn/JavaScript/Objects
Title: JavaScript 객체 소개
Flaw count: 104

  • macros:
    • /ko/docs/Learn/HTML/Introduction_to_HTML/Document_and_website_structure does not exist but fell back to /en-US/docs/Learn/HTML/Introduction_to_HTML/Document_and_website_structure
    • /ko/docs/Learn/HTML/Introduction_to_HTML/Debugging_HTML does not exist but fell back to /en-US/docs/Learn/HTML/Introduction_to_HTML/Debugging_HTML
    • /ko/docs/Learn/HTML/Multimedia_and_embedding/Video_and_audio_content does not exist but fell back to /en-US/docs/Learn/HTML/Multimedia_and_embedding/Video_and_audio_content
    • /ko/docs/Learn/HTML/Multimedia_and_embedding/Mozilla_splash_page does not exist but fell back to /en-US/docs/Learn/HTML/Multimedia_and_embedding/Mozilla_splash_page
    • /ko/docs/Learn/CSS/Building_blocks/Advanced_styling_effects does not exist but fell back to /en-US/docs/Learn/CSS/Building_blocks/Advanced_styling_effects
    • and 94 more flaws omitted
  • broken_links:
    • Can't resolve /ko/docs/Learn/Front-end_web_developer
    • Can't resolve /ko/docs/Web/Guide/HTML/Introduction
    • Can't resolve /ko/docs/Learn/CSS/Introduction_to_CSS
    • Can't resolve /ko/docs/Learn/JavaScript/Objects/Object-oriented_JS
    • Can't resolve /ko/docs/Learn/JavaScript/Objects/Inheritance

(comment last updated: 2024-07-31 02:27:51)

@queengooborg
Copy link
Collaborator Author

@hochan222 I know in #22758 (comment), I said that these GFM Alerts conversion PRs aren't blocking anything, but I forgot that converting the callouts was important to get done sooner -- would you be willing to give this PR a review before any of the other conversion PRs are looked at? Still no rush, just whenever you're able and interested -- thank you in advance!

sunhpark42
sunhpark42 approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@sunhpark42 sunhpark42 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@queengooborg
lgtm.
please resolve the conflicts. after resolving them I'll merge this PR.

@github-actions GitHub Actions
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot added the merge conflicts 🚧 This pull request has merge conflicts that must be resolved. label Jul 31, 2024
@github-actions github-actions bot removed the merge conflicts 🚧 This pull request has merge conflicts that must be resolved. label Jul 31, 2024
@queengooborg queengooborg merged commit 2a8a6f4 into main Jul 31, 2024
8 checks passed
@queengooborg queengooborg deleted the gfm-alerts/ko/callouts branch July 31, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunhpark42 sunhpark42 sunhpark42 approved these changes

Assignees
No one assigned
Labels
l10n-ko Issues related to Korean content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@queengooborg @sunhpark42