Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fr] use const instead of var in code examples #22879

Merged
merged 6 commits into from
Oct 10, 2024
Merged

Conversation

cricrio
Copy link
Contributor

@cricrio cricrio commented Aug 1, 2024

Description

I replaced all the 'var' by 'const' in the code examples.

Motivation

Additional details

Related issues and pull requests

cricrio added 2 commits August 1, 2024 18:19
Use `const` instead of `var`
@cricrio cricrio requested a review from a team as a code owner August 1, 2024 16:38
@cricrio cricrio requested review from tristantheb and removed request for a team August 1, 2024 16:38
@github-actions github-actions bot added the l10n-fr Issues related to French content. label Aug 1, 2024
Copy link
Contributor

github-actions bot commented Aug 1, 2024

Preview URLs

Flaws (1)

URL: /fr/docs/Web/API/Document/getElementById
Title: Document : La méthode getElementById()
Flaw count: 1

  • translation_differences:
    • Differences in the important macros (3 in common of 5 possible)

(comment last updated: 2024-10-10 12:14:10)

cw118
cw118 previously requested changes Aug 4, 2024
Copy link
Member

@cw118 cw118 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR @cricrio ! Just one small suggestion :)

files/fr/web/api/document/getelementbyid/index.md Outdated Show resolved Hide resolved
@leon-win leon-win changed the title Use 'const' instead of 'var' in code examples [fr] use 'const' instead of 'var' in code examples Aug 6, 2024
@leon-win leon-win changed the title [fr] use 'const' instead of 'var' in code examples [fr] use const instead of var in code examples Aug 6, 2024
* fix: typos
* updt: commit version
* updt: content and notes
* updt: links
* rem: macros to link
Copy link
Member

@tristantheb tristantheb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@cw118 cw118 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quelques suggestions, merci déjà @tristantheb !

files/fr/web/api/document/getelementbyid/index.md Outdated Show resolved Hide resolved
files/fr/web/api/document/getelementbyid/index.md Outdated Show resolved Hide resolved
files/fr/web/api/document/getelementbyid/index.md Outdated Show resolved Hide resolved
files/fr/web/api/document/getelementbyid/index.md Outdated Show resolved Hide resolved
@SphinxKnight SphinxKnight requested a review from cw118 October 10, 2024 12:23
@SphinxKnight SphinxKnight dismissed cw118’s stale review October 10, 2024 12:23

suggestion applied

@SphinxKnight SphinxKnight merged commit d85c322 into mdn:main Oct 10, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-fr Issues related to French content.
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants