Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web/CSS/CSS_flexible_box_layout/Basic_concepts_of_flexbox_basics_fix #23078

Merged
merged 10 commits into from
Sep 4, 2024
Merged

Web/CSS/CSS_flexible_box_layout/Basic_concepts_of_flexbox_basics_fix #23078

merged 10 commits into from
Sep 4, 2024

Conversation

PJW980921
Copy link
Contributor

Dscription
ko, fr, pt-br, ru/docs/Web/CSS/CSS_flexible_box_layout/Basic_concepts_of_flexbox 에 basics 이미지들이 png로 되어있어서 그런지 엑박인 상태로 화면에 보여집니다.

확장자 png를 svg로 수정했습니다.

스크린샷 2024-08-15 오후 7 07 16

@PJW980921 PJW980921 requested review from a team as code owners August 15, 2024 10:24
@PJW980921 PJW980921 requested review from leon-win, 1ilsang, tristantheb and clovislima and removed request for a team August 15, 2024 10:24
@github-actions github-actions bot added l10n-fr Issues related to French content. l10n-ru Issues related to Russian content. l10n-ko Issues related to Korean content. l10n-pt-br Issues related to Brazilian Portuguese labels Aug 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 15, 2024 •
edited
Loading

Preview URLs

Flaws (21)

URL: /ko/docs/Web/CSS/CSS_flexible_box_layout/Basic_concepts_of_flexbox
Title: flexbox의 기본 개념
Flaw count: 4

  • macros:
    • /ko/docs/Web/CSS/display does not exist but fell back to /en-US/docs/Web/CSS/display
  • broken_links:
    • Can't resolve /ko/docs/Web/CSS/CSS_Grid_Layout
    • Can't resolve /ko/docs/Web/CSS/CSS_Flexible_Box_Layout/Controlling_Ratios_of_Flex_Items_Along_the_Main_Ax
    • Can't resolve /ko/docs/Web/CSS/CSS_Flexible_Box_Layout/Controlling_Ratios_of_Flex_Items_Along_the_Main_Ax

URL: /pt-BR/docs/Web/CSS/CSS_flexible_box_layout/Basic_concepts_of_flexbox
Title: Conceitos básicos de flexbox
Flaw count: 8

  • macros:
    • /pt-BR/docs/Web/CSS/flex-basis does not exist but fell back to /en-US/docs/Web/CSS/flex-basis
    • /pt-BR/docs/Web/CSS/flex-grow does not exist but fell back to /en-US/docs/Web/CSS/flex-grow
    • /pt-BR/docs/Web/CSS/flex-shrink does not exist but fell back to /en-US/docs/Web/CSS/flex-shrink
    • /pt-BR/docs/Web/CSS/flex-basis does not exist but fell back to /en-US/docs/Web/CSS/flex-basis
    • /pt-BR/docs/Web/CSS/justify-content does not exist but fell back to /en-US/docs/Web/CSS/justify-content
  • broken_links:
    • Can't resolve /pt-BR/docs/Web/CSS/layout_de_grelha_css
    • Can't resolve /pt-BR/docs/Web/CSS/CSS_Flexible_Box_Layout/Controlling_Ratios_of_Flex_Items_Along_the_Main_Ax
    • Can't resolve /pt-BR/docs/Web/CSS/CSS_Flexible_Box_Layout/Aligning_Items_in_a_Flex_Container

URL: /fr/docs/Web/CSS/CSS_flexible_box_layout/Basic_concepts_of_flexbox
Title: Les concepts de base pour flexbox
Flaw count: 7

  • macros:
    • Wrong xref macro used (consider changing which macro you use). Error processing path /fr/docs/Web/CSS/:current
  • broken_links:
    • Can't resolve /fr/docs/Web/CSS/CSS_Grid_Layout
    • Can't resolve /fr/docs/Web/CSS/Disposition_flexbox_CSS/Maîtriser_passage_à_la_ligne_des_éléments_flexibles
    • Can't resolve /fr/docs/Web/CSS/Disposition_flexbox_CSS/Contrôler_les_proportions_des_boîtes_flexibles_le_long_de_l_axe_principal
    • Can't resolve /fr/docs/Web/CSS/Disposition_flexbox_CSS/Aligner_des_éléments_dans_un_conteneur_flexible
    • Can't resolve /fr/docs/Web/CSS/CSS_Flexible_Box_Layout/Relationship_of_Flexbox_to_Other_Layout_Methods
  • translation_differences:
    • Differences in the important macros (7 in common of 11 possible)

URL: /ru/docs/Web/CSS/CSS_flexible_box_layout/Basic_concepts_of_flexbox
Title: Основные понятия Flexbox
Flaw count: 2

  • broken_links:
    • Can't resolve /ru/docs/Web/CSS/CSS_Flexible_Box_Layout/Mastering_Wrapping_of_Flex_Items
    • Can't resolve /ru/docs/Web/CSS/CSS_Flexible_Box_Layout/Aligning_Items_in_a_Flex_Container

(comment last updated: 2024-08-20 03:30:50)

@PJW980921 PJW980921 changed the title Fix Modify image file extension from png to svg in Flexbox basic conc… Web/CSS/CSS_flexible_box_layout/Basic_concepts_of_flexbox_basics_fix Aug 15, 2024
cw118
cw118 approved these changes Aug 15, 2024
View reviewed changes
Copy link
Member

@cw118 cw118 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for fr, thank you @PJW980921 !

@PJW980921
Copy link
Contributor Author

Looks good for fr, thank you @PJW980921 !

You’re Welcome! Thank you for your comment!

1ilsang
1ilsang approved these changes Aug 16, 2024
View reviewed changes
Copy link
Member

@1ilsang 1ilsang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for ko. Thank you!

@PJW980921
Copy link
Contributor Author

Looks good for ko. Thank you!

감사합니다 😊

leon-win
leon-win reviewed Aug 18, 2024
View reviewed changes
Copy link
Member

@leon-win leon-win left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PJW980921 , thank you for fixing Russian version!

I have also added translations of image descriptions.

files/ru/web/css/css_flexible_box_layout/basic_concepts_of_flexbox/index.md Outdated Show resolved Hide resolved
files/ru/web/css/css_flexible_box_layout/basic_concepts_of_flexbox/index.md Outdated Show resolved Hide resolved
files/ru/web/css/css_flexible_box_layout/basic_concepts_of_flexbox/index.md Outdated Show resolved Hide resolved
files/ru/web/css/css_flexible_box_layout/basic_concepts_of_flexbox/index.md Outdated Show resolved Hide resolved
files/ru/web/css/css_flexible_box_layout/basic_concepts_of_flexbox/index.md Outdated Show resolved Hide resolved
files/ru/web/css/css_flexible_box_layout/basic_concepts_of_flexbox/index.md Outdated Show resolved Hide resolved
files/ru/web/css/css_flexible_box_layout/basic_concepts_of_flexbox/index.md Outdated Show resolved Hide resolved
@PJW980921
Copy link
Contributor Author

@PJW980921 , thank you for fixing Russian version!

I have also added translations of image descriptions.

Even the translation into Russian is so good! 👍🏻

PJW980921 and others added 5 commits August 20, 2024 12:24
@1ilsang
Copy link
Member

1ilsang commented Aug 24, 2024

@clovislima Hi, Could you check this PR?

@PJW980921
Copy link
Contributor Author

May I know when it will be merged?
@1ilsang

@1ilsang
Copy link
Member

1ilsang commented Sep 1, 2024

@mdn/yari-content-pt-br Hi, Can anyone help with this PR?

@PJW980921 This PR is without a Brazilian translation, so if they don't respond, I'll merge it in a week.

josielrocha
josielrocha approved these changes Sep 3, 2024
View reviewed changes
Copy link
Collaborator

@josielrocha josielrocha left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve for @mdn/yari-content-pt-br. 👍🏼

@1ilsang 1ilsang merged commit efcf341 into mdn:main Sep 4, 2024
7 checks passed
@leon-win leon-win mentioned this pull request Nov 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cw118 cw118 cw118 approved these changes

@1ilsang 1ilsang 1ilsang approved these changes

@tristantheb tristantheb tristantheb approved these changes

@leon-win leon-win leon-win approved these changes

@josielrocha josielrocha josielrocha approved these changes

@clovislima clovislima Awaiting requested review from clovislima clovislima is a code owner automatically assigned from mdn/yari-content-pt-br

Assignees
No one assigned
Labels
l10n-fr Issues related to French content. l10n-ko Issues related to Korean content. l10n-pt-br Issues related to Brazilian Portuguese l10n-ru Issues related to Russian content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@PJW980921 @1ilsang @josielrocha @leon-win @tristantheb @cw118