Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: code example #23441

Merged
merged 1 commit into from
Sep 17, 2024
Merged

fix: code example #23441

merged 1 commit into from
Sep 17, 2024

Conversation

PassionPenguin
Copy link
Contributor

fixes #23260 for zh-tw, pt-br, ko

@PassionPenguin PassionPenguin requested review from a team as code owners September 7, 2024 02:08
@PassionPenguin PassionPenguin requested review from wisedog, yin1999 and nathipg and removed request for a team September 7, 2024 02:08
@github-actions github-actions bot added l10n-zh Issues related to Chinese content. l10n-ko Issues related to Korean content. l10n-pt-br Issues related to Brazilian Portuguese labels Sep 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 7, 2024

Preview URLs

Flaws (385)

URL: /pt-BR/docs/Learn/Server-side/Django/Sessions
Title: Tutorial Django Parte 7: Sessões
Flaw count: 136

  • macros:
    • /pt-BR/docs/Learn/HTML/Introduction_to_HTML/Marking_up_a_letter does not exist but fell back to /en-US/docs/Learn/HTML/Introduction_to_HTML/Marking_up_a_letter
    • /pt-BR/docs/Learn/HTML/Introduction_to_HTML/Structuring_a_page_of_content does not exist but fell back to /en-US/docs/Learn/HTML/Introduction_to_HTML/Structuring_a_page_of_content
    • /pt-BR/docs/Learn/HTML/Multimedia_and_embedding/Mozilla_splash_page does not exist but fell back to /en-US/docs/Learn/HTML/Multimedia_and_embedding/Mozilla_splash_page
    • /pt-BR/docs/Learn/HTML/Tables/Advanced does not exist but fell back to /en-US/docs/Learn/HTML/Tables/Advanced
    • /pt-BR/docs/Learn/HTML/Tables/Structuring_planet_data does not exist but fell back to /en-US/docs/Learn/HTML/Tables/Structuring_planet_data
    • and 131 more flaws omitted

URL: /zh-TW/docs/Learn/Server-side/Django/Sessions
Title: Django Tutorial Part 7: Sessions framework
Flaw count: 150

  • macros:
    • /zh-TW/docs/Learn/HTML/Introduction_to_HTML/Advanced_text_formatting does not exist but fell back to /en-US/docs/Learn/HTML/Introduction_to_HTML/Advanced_text_formatting
    • /zh-TW/docs/Learn/HTML/Introduction_to_HTML/Debugging_HTML does not exist but fell back to /en-US/docs/Learn/HTML/Introduction_to_HTML/Debugging_HTML
    • /zh-TW/docs/Learn/HTML/Introduction_to_HTML/Marking_up_a_letter does not exist but fell back to /en-US/docs/Learn/HTML/Introduction_to_HTML/Marking_up_a_letter
    • /zh-TW/docs/Learn/HTML/Introduction_to_HTML/Structuring_a_page_of_content does not exist but fell back to /en-US/docs/Learn/HTML/Introduction_to_HTML/Structuring_a_page_of_content
    • /zh-TW/docs/Learn/HTML/Multimedia_and_embedding/Video_and_audio_content does not exist but fell back to /en-US/docs/Learn/HTML/Multimedia_and_embedding/Video_and_audio_content
    • and 145 more flaws omitted

URL: /ko/docs/Learn/Server-side/Django/Sessions
Title: Django Tutorial Part 7: Sessions framework
Flaw count: 99

  • macros:
    • /ko/docs/Learn/HTML/Introduction_to_HTML/Document_and_website_structure does not exist but fell back to /en-US/docs/Learn/HTML/Introduction_to_HTML/Document_and_website_structure
    • /ko/docs/Learn/HTML/Introduction_to_HTML/Debugging_HTML does not exist but fell back to /en-US/docs/Learn/HTML/Introduction_to_HTML/Debugging_HTML
    • /ko/docs/Learn/HTML/Multimedia_and_embedding/Video_and_audio_content does not exist but fell back to /en-US/docs/Learn/HTML/Multimedia_and_embedding/Video_and_audio_content
    • /ko/docs/Learn/HTML/Multimedia_and_embedding/Mozilla_splash_page does not exist but fell back to /en-US/docs/Learn/HTML/Multimedia_and_embedding/Mozilla_splash_page
    • /ko/docs/Learn/CSS/Building_blocks/Advanced_styling_effects does not exist but fell back to /en-US/docs/Learn/CSS/Building_blocks/Advanced_styling_effects
    • and 94 more flaws omitted

yin1999
yin1999 approved these changes Sep 7, 2024
View reviewed changes
Copy link
Member

@yin1999 yin1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for l10n-zh

wisedog
wisedog approved these changes Sep 7, 2024
View reviewed changes
Copy link
Contributor

@wisedog wisedog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for KO

josielrocha
josielrocha approved these changes Sep 15, 2024
View reviewed changes
Copy link
Collaborator

@josielrocha josielrocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for pt-BR

@yin1999 yin1999 merged commit 12f3830 into mdn:main Sep 17, 2024
6 checks passed
@PassionPenguin PassionPenguin deleted the code-example branch September 17, 2024 08:03
sora32127 pushed a commit to sora32127/translated-content that referenced this pull request Oct 6, 2024
@PassionPenguin @sora32127
fix: code example (mdn#23441)
6d2caef
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yin1999 yin1999 yin1999 approved these changes

@wisedog wisedog wisedog approved these changes

@josielrocha josielrocha josielrocha approved these changes

@nathipg nathipg Awaiting requested review from nathipg nathipg is a code owner automatically assigned from mdn/yari-content-pt-br

Assignees
No one assigned
Labels
l10n-ko Issues related to Korean content. l10n-pt-br Issues related to Brazilian Portuguese l10n-zh Issues related to Chinese content.
Projects
MDN translated-content l10n-zh
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Small mistake for value is not updated in code example
4 participants
@PassionPenguin @josielrocha @wisedog @yin1999