Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(ko): Add Korean translation of fit-content #23514

Merged
merged 8 commits into from
Sep 29, 2024
Merged

docs(ko): Add Korean translation of fit-content #23514

merged 8 commits into from
Sep 29, 2024

Conversation

C17AN
Copy link
Contributor

@C17AN C17AN commented Sep 11, 2024 •
edited
Loading

Description

  • CSS 키워드 중 fit-content 문서의 한글 번역을 추가합니다.

Additional details

@C17AN C17AN requested a review from a team as a code owner September 11, 2024 12:48
@C17AN C17AN requested review from hochan222 and removed request for a team September 11, 2024 12:48
@github-actions github-actions bot added the l10n-ko Issues related to Korean content. label Sep 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 11, 2024 •
edited
Loading

Preview URLs

Flaws (6)

URL: /ko/docs/Web/CSS/fit-content
Title: fit-content
Flaw count: 6

  • macros:
    • /ko/docs/Web/CSS/fit-content_function does not exist but fell back to /en-US/docs/Web/CSS/fit-content_function
    • /ko/docs/Web/CSS/max-content does not exist but fell back to /en-US/docs/Web/CSS/max-content
    • /ko/docs/Web/CSS/fit-content_function does not exist but fell back to /en-US/docs/Web/CSS/fit-content_function
    • /ko/docs/Web/CSS/min-content does not exist but fell back to /en-US/docs/Web/CSS/min-content
    • /ko/docs/Web/CSS/max-content does not exist but fell back to /en-US/docs/Web/CSS/max-content
  • translation_differences:
    • Differences in the important macros (3 in common of 5 possible)

(comment last updated: 2024-09-29 12:45:58)

@C17AN
Copy link
Contributor Author

C17AN commented Sep 11, 2024 •
edited
Loading

안녕하세요, @hochan222 님!
본업으로 바쁜 와중에도 리뷰해주셔서 항상 감사드립니다!

이번에도 잘 부탁드리며, 수정이 필요한 부분이 있다면 편히 말씀 부탁드리겠습니다! 🙇‍♂️

hochan222
hochan222 approved these changes Sep 29, 2024
View reviewed changes
Copy link
Member

@hochan222 hochan222 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@C17AN 님 안녕하세요.

내용 넘 좋습니다. 고생 정말 많으셨습니다.

좋은 하루 보내세요 :)

hochan222
hochan222 approved these changes Sep 29, 2024
View reviewed changes
Copy link
Member

@hochan222 hochan222 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@C17AN 님 아래 sub title들은 용어 안내서에 따라 각각 아래와 같이 수정되어야합니다.

내용 크지 않아 수정 후 병합하겠습니다~!

files/ko/web/css/fit-content/index.md Outdated Show resolved Hide resolved
files/ko/web/css/fit-content/index.md Outdated Show resolved Hide resolved
@hochan222 hochan222 merged commit b73e329 into mdn:main Sep 29, 2024
7 checks passed
sora32127 pushed a commit to sora32127/translated-content that referenced this pull request Oct 6, 2024
@C17AN @hochan222 @sora32127
docs(ko): Add Korean translation of fit-content (mdn#23514)
15cfc08 
* docs(ko): add korean translation of fit-content

* chore: translate code example

* fix: fix EmbedLiveSample

* chore: fix awkward translation

* chore: fix awkward translation

* chore: fix awkward translation

* Update files/ko/web/css/fit-content/index.md

* Update files/ko/web/css/fit-content/index.md

---------

Co-authored-by: hochan Lee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hochan222 hochan222 hochan222 approved these changes

Assignees
No one assigned
Labels
l10n-ko Issues related to Korean content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@C17AN @hochan222