Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[zh-cn]: sync translation for Picture-in-Picture API & add translation for ShadowRoot.pictureInPictureElement #23556

Merged
merged 6 commits into from
Sep 27, 2024
Merged

[zh-cn]: sync translation for Picture-in-Picture API & add translation for ShadowRoot.pictureInPictureElement #23556

merged 6 commits into from
Sep 27, 2024

Conversation

skyclouds2001
Copy link
Contributor

@skyclouds2001 skyclouds2001 commented Sep 14, 2024 •
edited
Loading

Description

Motivation

Additional details

Related issues and pull requests

part of the #23557

depends on mdn/content#35887

@github-actions github-actions bot added the l10n-zh Issues related to Chinese content. label Sep 14, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 14, 2024 •
edited
Loading

Preview URLs (7 pages)
Flaws (7)

Note! 3 documents with no flaws that don't need to be listed. 🎉

URL: /zh-CN/docs/Web/HTTP/Headers/Permissions-Policy/picture-in-picture
Title: Permissions-Policy: picture-in-picture
Flaw count: 1

  • macros:
    • /zh-CN/docs/Web/URI does not exist but fell back to /en-US/docs/Web/URI

URL: /zh-CN/docs/Web/API/HTMLVideoElement/enterpictureinpicture_event
Title: HTMLVideoElement：enterpictureinpicture 事件
Flaw count: 1

  • macros:
    • /zh-CN/docs/Web/API/PictureInPictureEvent does not exist but fell back to /en-US/docs/Web/API/PictureInPictureEvent

URL: /zh-CN/docs/Web/API/HTMLVideoElement/leavepictureinpicture_event
Title: HTMLVideoElement：leavepictureinpicture 事件
Flaw count: 3

  • macros:
    • /zh-CN/docs/Web/API/PictureInPictureEvent does not exist but fell back to /en-US/docs/Web/API/PictureInPictureEvent
    • /zh-CN/docs/Web/API/PictureInPictureEvent does not exist but fell back to /en-US/docs/Web/API/PictureInPictureEvent
  • translation_differences:
    • Differences in the important macros (2 in common of 4 possible)

URL: /zh-CN/docs/Web/API/Picture-in-Picture_API
Title: 画中画 API
Flaw count: 2

  • macros:
    • /zh-CN/docs/Web/API/PictureInPictureWindow/onresize does not exist but fell back to /en-US/docs/Web/API/PictureInPictureWindow/resize_event
    • /zh-CN/docs/Web/API/PictureInPictureEvent does not exist but fell back to /en-US/docs/Web/API/PictureInPictureEvent

(comment last updated: 2024-09-27 14:07:14)

@skyclouds2001 skyclouds2001 mentioned this pull request Sep 14, 2024
Closed
@skyclouds2001 skyclouds2001 marked this pull request as ready for review September 23, 2024 12:33
@skyclouds2001 skyclouds2001 requested a review from a team as a code owner September 23, 2024 12:33
@skyclouds2001 skyclouds2001 requested review from irvin and removed request for a team September 23, 2024 12:34
yin1999
yin1999 approved these changes Sep 27, 2024
View reviewed changes
Copy link
Member

@yin1999 yin1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@yin1999 yin1999 merged commit e8b7618 into mdn:main Sep 27, 2024
7 checks passed
@skyclouds2001 skyclouds2001 deleted the Picture-in-Picture_API branch September 27, 2024 14:24
sora32127 pushed a commit to sora32127/translated-content that referenced this pull request Oct 6, 2024
@skyclouds2001 @yin1999 @sora32127
[zh-cn]: sync translation for Picture-in-Picture API & add translatio…
f965ed7 
…n for `ShadowRoot.pictureInPictureElement` (mdn#23556)

Co-authored-by: A1lo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yin1999 yin1999 yin1999 approved these changes

@irvin irvin Awaiting requested review from irvin irvin is a code owner automatically assigned from mdn/yari-content-zh

Assignees
No one assigned
Labels
l10n-zh Issues related to Chinese content.
Projects
MDN translated-content l10n-zh
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skyclouds2001 @yin1999