Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[zh-CN]: sync translation for Notifications API & Battery Status API #23615

Merged
merged 7 commits into from
Sep 23, 2024
Merged

[zh-CN]: sync translation for Notifications API & Battery Status API #23615

merged 7 commits into from
Sep 23, 2024

Conversation

skyclouds2001
Copy link
Contributor

@skyclouds2001 skyclouds2001 commented Sep 16, 2024 •
edited
Loading

Description

Motivation

Additional details

Related issues and pull requests

depends on mdn/content#35901 and mdn/content#35904

@github-actions github-actions bot added the l10n-zh Issues related to Chinese content. label Sep 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 16, 2024 •
edited
Loading

Preview URLs (22 pages)
Flaws (6)

Note! 16 documents with no flaws that don't need to be listed. 🎉

URL: /zh-CN/docs/Web/API/BatteryManager/dischargingTime
Title: BatteryManager：dischargingTime 属性
Flaw count: 1

  • translation_differences:
    • Differences in the important macros (3 in common of 5 possible)

URL: /zh-CN/docs/Web/API/BatteryManager/chargingTime
Title: BatteryManager：chargingTime 属性
Flaw count: 1

  • translation_differences:
    • Differences in the important macros (3 in common of 5 possible)

URL: /zh-CN/docs/Web/API/Battery_Status_API
Title: Battery Status API
Flaw count: 1

  • macros:
    • /zh-CN/docs/Web/API/WorkerNavigator does not exist but fell back to /en-US/docs/Web/API/WorkerNavigator

URL: /zh-CN/docs/Web/API/Notifications_API/Using_the_Notifications_API
Title: 使用 Notifications API
Flaw count: 1

  • translation_differences:
    • Differences in the important macros (2 in common of 4 possible)

URL: /zh-CN/docs/Web/API/ServiceWorkerRegistration/showNotification
Title: ServiceWorkerRegistration：showNotification() 方法
Flaw count: 1

  • macros:
    • /zh-CN/docs/Web/API/ServiceWorkerRegistration does not exist but fell back to /en-US/docs/Web/API/ServiceWorkerRegistration

URL: /zh-CN/docs/Web/API/NotificationEvent/NotificationEvent
Title: NotificationEvent：NotificationEvent() 构造函数
Flaw count: 1

  • macros:
    • /zh-CN/docs/Web/API/ExtendableEvent/ExtendableEvent does not exist but fell back to /en-US/docs/Web/API/ExtendableEvent/ExtendableEvent
External URLs (2)

URL: /zh-CN/docs/Web/API/Notification/Notification
Title: Notification：Notification() 构造函数

URL: /zh-CN/docs/Web/API/ServiceWorkerRegistration/showNotification
Title: ServiceWorkerRegistration：showNotification() 方法

(comment last updated: 2024-09-23 12:38:20)

@skyclouds2001 @github-actions
Apply suggestions from code review
4eab84e 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@skyclouds2001 skyclouds2001 marked this pull request as ready for review September 19, 2024 03:30
@skyclouds2001 skyclouds2001 requested a review from a team as a code owner September 19, 2024 03:30
@skyclouds2001 skyclouds2001 requested review from t7yang and removed request for a team September 19, 2024 03:30
yin1999
yin1999 reviewed Sep 23, 2024
View reviewed changes
Copy link
Member

@yin1999 yin1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

一些建议

files/zh-cn/web/api/notification/requestpermission_static/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/api/notification/requestpermission_static/index.md Show resolved Hide resolved
files/zh-cn/web/api/notifications_api/using_the_notifications_api/index.md Outdated Show resolved Hide resolved
yin1999
yin1999 approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member

@yin1999 yin1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@yin1999 yin1999 merged commit ed57344 into mdn:main Sep 23, 2024
7 checks passed
@skyclouds2001 skyclouds2001 deleted the notification branch September 23, 2024 14:06
sora32127 pushed a commit to sora32127/translated-content that referenced this pull request Oct 6, 2024
@skyclouds2001 @github-actions
@yin1999 @sora32127
[zh-CN]: sync translation for Notifications API & Battery Status API (m…
598f8af 
…dn#23615)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: A1lo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@yin1999 yin1999 yin1999 approved these changes

@t7yang t7yang Awaiting requested review from t7yang t7yang is a code owner automatically assigned from mdn/yari-content-zh

Assignees
No one assigned
Labels
l10n-zh Issues related to Chinese content.
Projects
MDN translated-content l10n-zh
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skyclouds2001 @yin1999