Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ko] accessibility/aria/roles/landmark_role 신규 번역 #23894

Merged
merged 4 commits into from
Oct 10, 2024

Conversation

0jenn0
Copy link
Contributor

@0jenn0 0jenn0 commented Oct 3, 2024

Description

안녕하세요 landmark_role 페이지 신규 번역했습니다!

@0jenn0 0jenn0 requested a review from a team as a code owner October 3, 2024 08:31
@0jenn0 0jenn0 requested review from wisedog and removed request for a team October 3, 2024 08:31
@github-actions github-actions bot added the l10n-ko Issues related to Korean content. label Oct 3, 2024
Copy link
Contributor

github-actions bot commented Oct 3, 2024

Preview URLs

Flaws (19)

URL: /ko/docs/Web/Accessibility/ARIA/Roles/landmark_role
Title: ARIA: landmark 역할
Flaw count: 19

  • macros:
    • /ko/docs/Web/Accessibility/Information_for_Web_authors does not exist but fell back to /en-US/docs/Web/Accessibility/Information_for_Web_authors
    • /ko/docs/Web/Accessibility/Accessibility:_What_users_can_to_to_browse_safely does not exist but fell back to /en-US/docs/Web/Accessibility/Accessibility:_What_users_can_to_to_browse_safely
    • /ko/docs/Web/Accessibility/An_overview_of_accessible_web_applications_and_widgets does not exist but fell back to /en-US/docs/Web/Accessibility/An_overview_of_accessible_web_applications_and_widgets
    • /ko/docs/Web/Accessibility/Keyboard-navigable_JavaScript_widgets does not exist but fell back to /en-US/docs/Web/Accessibility/Keyboard-navigable_JavaScript_widgets
    • /ko/docs/Web/Accessibility/Cognitive_accessibility does not exist but fell back to /en-US/docs/Web/Accessibility/Cognitive_accessibility
    • and 14 more flaws omitted
External URLs (1)

URL: /ko/docs/Web/Accessibility/ARIA/Roles/landmark_role
Title: ARIA: landmark 역할

(comment last updated: 2024-10-09 08:46:38)

0jenn0 and others added 2 commits October 3, 2024 17:34
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
- [ARIA: `navigation` 역할](/ko/docs/Web/Accessibility/ARIA/Roles/navigation_role)
- [ARIA: `region` 역할](/ko/docs/Web/Accessibility/ARIA/Roles/region_role)
- [ARIA: `search` 역할](/ko/docs/Web/Accessibility/ARIA/Roles/search_role)
- [접근성 향상을 위한 HTML 랜드마크 역할 사용하기](https://developer.mozilla.org/en-US/blog/aria-accessibility-html-landmark-roles/) (MDN 블로그, 2023)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ko/blog/aria-accessibility-html-landmark-roles/ 로 했더니
preview 사이트에서
스크린샷 2024-10-03 오후 5 20 31

위와 같이 보이길래 지금처럼 수정했는데 괜찮을까요?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

괜찮을 것 같습니다. 👍

Copy link
Contributor

@wisedog wisedog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰가 좀 늦었습니다. 하나만 수정 부탁드릴께요

---
title: "ARIA: landmark 역할"
slug: Web/Accessibility/ARIA/Roles/landmark_role
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

관련 가이드를 참고해서 i18n을 넣어주세요!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

가이드 문서에 l10n.*1만 사용합니다. 라고 되어있어서 l10n 추가로 수정했는데 아니면 다시 수정하겠습니다!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아 l10n 이었군요;;; -ㅁ-

@0jenn0 0jenn0 requested a review from wisedog October 9, 2024 08:50
Copy link
Contributor

@wisedog wisedog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wisedog wisedog merged commit 60f7eb7 into mdn:main Oct 10, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-ko Issues related to Korean content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants