Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[es, fr, ja, ko, pt-br, ru, zh-cn, zh-tw]: correct image file paths and demos paths #24765

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

OHMORIYUSUKE
Copy link
Contributor

@OHMORIYUSUKE OHMORIYUSUKE commented Nov 25, 2024

Description

Issue #24373 has been addressed.
Other image files had also been changed. For example, starsolid.gif was renamed to star-solid.gif. Therefore, the file paths have been corrected.

This problem occurs in the documentation for each language. All have been corrected in this Pull Request.

Motivation

If images and demos are not displayed correctly, they will confuse people referring to the document.

Additional details

Related issues and pull requests

Fixes #24373

@OHMORIYUSUKE OHMORIYUSUKE requested review from a team as code owners November 25, 2024 18:16
@OHMORIYUSUKE OHMORIYUSUKE requested review from Jalkhov, leon-win, 1ilsang, mfuji09, cw118, JasonLamv-t and nathipg and removed request for a team November 25, 2024 18:16
@github-actions github-actions bot added l10n-ja Issues related to Japanese content. l10n-fr Issues related to French content. l10n-zh Issues related to Chinese content. l10n-es Issues related to Spanish content. l10n-ru Issues related to Russian content. l10n-ko Issues related to Korean content. l10n-pt-br Issues related to Brazilian Portuguese labels Nov 25, 2024
Copy link
Contributor

github-actions bot commented Nov 25, 2024

Preview URLs (39 pages)
Flaws (197)

Note! 2 documents with no flaws that don't need to be listed. 🎉

URL: /ko/docs/Web/CSS/background-image
Title: background-image
Flaw count: 12

  • macros:
    • /ko/docs/Web/CSS/CSS_animated_properties does not exist but fell back to /en-US/docs/Web/CSS/CSS_animated_properties
    • /ko/docs/Web/CSS/linear-gradient does not exist but fell back to /en-US/docs/Web/CSS/gradient/linear-gradient
    • /ko/docs/Web/CSS/radial-gradient does not exist but fell back to /en-US/docs/Web/CSS/gradient/radial-gradient
    • /ko/docs/Web/CSS/repeating-linear-gradient does not exist but fell back to /en-US/docs/Web/CSS/gradient/repeating-linear-gradient
    • /ko/docs/Web/CSS/repeating-radial-gradient does not exist but fell back to /en-US/docs/Web/CSS/gradient/repeating-radial-gradient
    • and 4 more flaws omitted
  • broken_links:
    • Can't resolve /ko/docs/Web/CSS/CSS_Backgrounds_and_Borders/Using_multiple_backgrounds
    • Can't resolve /ko/docs/Web/CSS/CSS_Images/Implementing_image_sprites_in_CSS
  • translation_differences:
    • Differences in the important macros (5 in common of 7 possible)

URL: /ko/docs/Web/CSS/background
Title: background
Flaw count: 9

  • macros:
    • /ko/docs/Web/CSS/background-position does not exist but fell back to /en-US/docs/Web/CSS/background-position
    • /ko/docs/Web/CSS/background-size does not exist but fell back to /en-US/docs/Web/CSS/background-size
    • /ko/docs/Web/CSS/background-position does not exist but fell back to /en-US/docs/Web/CSS/background-position
    • /ko/docs/Web/CSS/background-size does not exist but fell back to /en-US/docs/Web/CSS/background-size
    • /ko/docs/Web/CSS/CSS_animated_properties does not exist but fell back to /en-US/docs/Web/CSS/CSS_animated_properties
    • and 1 more flaws omitted
  • broken_links:
    • Can't resolve /ko/docs/Web/CSS/CSS_Images/Using_CSS_gradients
    • Can't resolve /ko/docs/Web/CSS/CSS_Backgrounds_and_Borders/Using_multiple_backgrounds
  • translation_differences:
    • Differences in the important macros (5 in common of 7 possible)

URL: /ko/docs/Web/CSS/background-repeat
Title: background-repeat
Flaw count: 5

  • macros:
    • /ko/docs/Web/CSS/background-position does not exist but fell back to /en-US/docs/Web/CSS/background-position
    • /ko/docs/Web/CSS/background-position does not exist but fell back to /en-US/docs/Web/CSS/background-position
    • /ko/docs/Web/CSS/CSS_animated_properties does not exist but fell back to /en-US/docs/Web/CSS/CSS_animated_properties
  • broken_links:
    • Can't resolve /ko/docs/Web/CSS/CSS_Backgrounds_and_Borders/Using_multiple_backgrounds
  • translation_differences:
    • Differences in the important macros (5 in common of 7 possible)

URL: /ko/docs/Web/CSS/background-attachment
Title: background-attachment
Flaw count: 4

  • macros:
    • /ko/docs/Web/CSS/CSS_animated_properties does not exist but fell back to /en-US/docs/Web/CSS/CSS_animated_properties
  • broken_links:
    • Can't resolve /ko/docs/CSS
    • Can't resolve /ko/docs/Web/CSS/CSS_Backgrounds_and_Borders/Using_multiple_backgrounds
  • translation_differences:
    • Differences in the important macros (5 in common of 9 possible)

URL: /ja/docs/Web/CSS/list-style-image
Title: list-style-image
Flaw count: 2

  • macros:
    • /ja/docs/Web/CSS/url redirects to /ja/docs/Web/CSS/url_value
  • translation_differences:
    • Differences in the important macros (5 in common of 9 possible)

URL: /ja/docs/Web/CSS/background
Title: background
Flaw count: 1

  • translation_differences:
    • Differences in the important macros (5 in common of 7 possible)

URL: /ja/docs/Web/CSS/background-repeat
Title: background-repeat
Flaw count: 1

  • translation_differences:
    • Differences in the important macros (5 in common of 7 possible)

URL: /ja/docs/Web/CSS/background-attachment
Title: background-attachment
Flaw count: 1

  • translation_differences:
    • Differences in the important macros (5 in common of 9 possible)

URL: /zh-TW/docs/Web/CSS/background-attachment
Title: background-attachment
Flaw count: 4

  • macros:
    • /zh-TW/docs/Web/CSS/background-clip does not exist but fell back to /en-US/docs/Web/CSS/background-clip
    • /zh-TW/docs/Web/CSS/initial_value does not exist
    • /zh-TW/docs/Web/CSS/computed_value does not exist but fell back to /en-US/docs/Web/CSS/computed_value
    • /zh-TW/docs/Web/CSS/CSS_animated_properties does not exist but fell back to /en-US/docs/Web/CSS/CSS_animated_properties

URL: /es/docs/Web/CSS/list-style-image
Title: list-style-image
Flaw count: 8

  • macros:
    • /es/docs/Web/CSS/none redirects to /es/docs/Web/CSS/float
    • /es/docs/Web/CSS/Media:Visual does not exist
    • /es/docs/Web/CSS/computed%20value does not exist
  • broken_links:
    • Can't resolve /es/HTML/Element/li
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://
  • translation_differences:
    • Differences in the important macros (1 in common of 8 possible)

URL: /es/docs/Web/CSS/background-image
Title: background-image
Flaw count: 14

  • macros:
    • /es/docs/Web/CSS/CSS_animated_properties does not exist but fell back to /en-US/docs/Web/CSS/CSS_animated_properties
    • /es/docs/Web/CSS/cross-fade does not exist but fell back to /en-US/docs/Web/CSS/cross-fade
    • /es/docs/Web/CSS/element does not exist but fell back to /en-US/docs/Web/CSS/element
    • /es/docs/Web/CSS/image/image does not exist but fell back to /en-US/docs/Web/CSS/image/image
    • /es/docs/Web/CSS/image/image-set does not exist but fell back to /en-US/docs/Web/CSS/image/image-set
    • and 7 more flaws omitted
  • broken_links:
    • Can't resolve /es/docs/Web/CSS/CSS_Backgrounds_and_Borders/Using_multiple_backgrounds
  • translation_differences:
    • Differences in the important macros (5 in common of 7 possible)

URL: /es/docs/Web/CSS/background
Title: background
Flaw count: 8

  • macros:
    • /es/docs/Web/CSS/Media:Visual does not exist
    • /es/docs/Web/CSS/computed%20value does not exist
  • broken_links:
    • Can't resolve /es/CSS/background-color
    • Can't resolve /es/CSS/background-image
    • Can't resolve /es/CSS/background-repeat
    • Can't resolve /es/CSS/background-attachment
    • Can't resolve /es/CSS/background-position
  • translation_differences:
    • Differences in the important macros (3 in common of 7 possible)

URL: /es/docs/Web/CSS/background-repeat
Title: background-repeat
Flaw count: 3

  • macros:
    • /es/docs/Web/CSS/CSS_animated_properties does not exist but fell back to /en-US/docs/Web/CSS/CSS_animated_properties
  • broken_links:
    • Can't resolve /es/docs/Web/CSS/CSS_Backgrounds_and_Borders/Using_multiple_backgrounds
  • translation_differences:
    • Differences in the important macros (5 in common of 7 possible)

URL: /es/docs/Web/CSS/list-style-position
Title: list-style-position
Flaw count: 7

  • macros:
    • /es/docs/Web/CSS/outside does not exist
    • /es/docs/Web/CSS/Media:Visual does not exist
    • /es/docs/Web/CSS/computed%20value does not exist
  • broken_links:
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://
  • translation_differences:
    • Differences in the important macros (1 in common of 7 possible)

URL: /es/docs/Web/CSS/background-attachment
Title: background-attachment
Flaw count: 3

  • macros:
    • /es/docs/Web/CSS/Media:Visual does not exist
    • /es/docs/Web/CSS/computed%20value does not exist
  • translation_differences:
    • Differences in the important macros (3 in common of 9 possible)

URL: /zh-CN/docs/Web/CSS/list-style-image
Title: list-style-image
Flaw count: 1

  • translation_differences:
    • Differences in the important macros (4 in common of 8 possible)

URL: /zh-CN/docs/Web/CSS/background-image
Title: background-image
Flaw count: 8

  • macros:
    • /zh-CN/docs/Web/CSS/cross-fade does not exist but fell back to /en-US/docs/Web/CSS/cross-fade
    • /zh-CN/docs/Web/CSS/image/image does not exist but fell back to /en-US/docs/Web/CSS/image/image
    • /zh-CN/docs/Web/CSS/image/image-set does not exist but fell back to /en-US/docs/Web/CSS/image/image-set
    • /zh-CN/docs/Web/CSS/gradient/repeating-conic-gradient does not exist but fell back to /en-US/docs/Web/CSS/gradient/repeating-conic-gradient
    • /zh-CN/docs/Web/CSS/image/paint does not exist but fell back to /en-US/docs/Web/CSS/image/paint
  • broken_links:
    • Can't resolve /zh-CN/CSS/border
    • Can't resolve /zh-CN/docs/Web/CSS/CSS_Background_and_Borders/Using_CSS_multiple_backgrounds
  • translation_differences:
    • Differences in the important macros (5 in common of 7 possible)

URL: /zh-CN/docs/Web/CSS/background
Title: background
Flaw count: 5

  • macros:
    • /zh-CN/docs/Web/CSS/-moz-background-size does not exist but fell back to /en-US/docs/Web/CSS/background-size
    • /zh-CN/docs/Web/CSS/-moz-background-inline-policy does not exist but fell back to /en-US/docs/Web/CSS/box-decoration-break
  • broken_links:
    • Can't resolve /zh-CN/docs/CSS/Using_CSS_gradients
    • Can't resolve /zh-CN/docs/CSS/Multiple_backgrounds
  • translation_differences:
    • Differences in the important macros (5 in common of 7 possible)

URL: /zh-CN/docs/Web/CSS/background-repeat
Title: background-repeat
Flaw count: 2

  • broken_links:
    • Can't resolve /zh-CN/docs/CSS
  • translation_differences:
    • Differences in the important macros (5 in common of 7 possible)

URL: /zh-CN/docs/Web/CSS/list-style-position
Title: list-style-position
Flaw count: 1

  • translation_differences:
    • Differences in the important macros (4 in common of 7 possible)

URL: /zh-CN/docs/Web/CSS/background-attachment
Title: background-attachment
Flaw count: 4

  • macros:
    • /zh-CN/docs/Glossary/%E8%A7%86%E5%8F%A3 does not exist
  • broken_links:
    • Can't resolve /zh-CN/docs/CSS
    • Can't resolve /zh-CN/docs/CSS/Multiple_backgrounds
  • translation_differences:
    • Differences in the important macros (5 in common of 9 possible)

URL: /zh-CN/docs/Web/CSS/background-position
Title: background-position
Flaw count: 1

  • translation_differences:
    • Differences in the important macros (5 in common of 7 possible)

URL: /ru/docs/Web/CSS/list-style-image
Title: list-style-image
Flaw count: 8

  • macros:
    • /ru/docs/Web/CSS/list-style does not exist but fell back to /en-US/docs/Web/CSS/list-style
    • /ru/docs/Web/CSS/url does not exist but fell back to /en-US/docs/Web/CSS/url_value
    • /ru/docs/Web/CSS/list-style-type does not exist but fell back to /en-US/docs/Web/CSS/list-style-type
    • Wrong xref macro used (consider changing which macro you use). Error processing path /ru/docs/Web/CSS/CSS_animated_properties
    • /ru/docs/Web/CSS/list-style does not exist but fell back to /en-US/docs/Web/CSS/list-style
    • and 2 more flaws omitted
  • translation_differences:
    • Differences in the important macros (5 in common of 8 possible)

URL: /ru/docs/Web/CSS/background-image
Title: background-image
Flaw count: 13

  • macros:
    • Wrong xref macro used (consider changing which macro you use). Error processing path /ru/docs/Web/CSS/CSS_animated_properties
    • /ru/docs/Web/CSS/image does not exist but fell back to /en-US/docs/Web/CSS/image
    • /ru/docs/Web/CSS/image does not exist but fell back to /en-US/docs/Web/CSS/image
    • /ru/docs/Web/CSS/linear-gradient does not exist but fell back to /en-US/docs/Web/CSS/gradient/linear-gradient
    • /ru/docs/Web/CSS/radial-gradient does not exist but fell back to /en-US/docs/Web/CSS/gradient/radial-gradient
    • and 3 more flaws omitted
  • broken_links:
    • Can't resolve /ru/docs/CSS
    • Can't resolve /ru/CSS/border
    • Can't resolve /ru/docs/CSS/Multiple_backgrounds
    • Can't resolve /ru/docs/Web/Guide/CSS/CSS_Image_Sprites
  • translation_differences:
    • Differences in the important macros (3 in common of 8 possible)

URL: /ru/docs/Web/CSS/background
Title: background
Flaw count: 4

  • macros:
    • /ru/docs/Web/CSS/-moz-background-inline-policy does not exist but fell back to /en-US/docs/Web/CSS/box-decoration-break
  • broken_links:
    • Can't resolve /ru/docs/CSS/Using_CSS_gradients
    • Can't resolve /ru/docs/CSS/Multiple_backgrounds
  • translation_differences:
    • Differences in the important macros (5 in common of 7 possible)

URL: /ru/docs/Web/CSS/background-repeat
Title: background-repeat
Flaw count: 3

  • macros:
    • Wrong xref macro used (consider changing which macro you use). Error processing path /ru/docs/Web/CSS/CSS_animated_properties
  • broken_links:
    • Can't resolve /ru/docs/CSS/Using_CSS_multiple_backgrounds
  • translation_differences:
    • Differences in the important macros (4 in common of 7 possible)

URL: /ru/docs/Web/CSS/background-attachment
Title: background-attachment
Flaw count: 4

  • macros:
    • Wrong xref macro used (consider changing which macro you use). Error processing path /ru/docs/Web/CSS/CSS_animated_properties
  • broken_links:
    • Can't resolve /ru/docs/CSS
    • Can't resolve /ru/docs/CSS/Multiple_backgrounds
  • translation_differences:
    • Differences in the important macros (4 in common of 9 possible)

URL: /ru/docs/Web/CSS/background-position
Title: background-position
Flaw count: 9

  • macros:
    • /ru/docs/Web/CSS/position_value does not exist but fell back to /en-US/docs/Web/CSS/position_value
    • Wrong xref macro used (consider changing which macro you use). Error processing path /ru/docs/Web/CSS/CSS_animated_properties
    • /ru/docs/Web/CSS/position_value does not exist but fell back to /en-US/docs/Web/CSS/position_value
    • /ru/docs/Web/CSS/background-position-y does not exist but fell back to /en-US/docs/Web/CSS/background-position-y
    • /ru/docs/Web/CSS/background-position-inline does not exist
    • and 2 more flaws omitted
  • broken_links:
    • Can't resolve /ru/docs/Web/CSS/Multiple_backgrounds
  • translation_differences:
    • Differences in the important macros (5 in common of 7 possible)

URL: /pt-BR/docs/Web/CSS/background
Title: background
Flaw count: 11

  • macros:
    • /pt-BR/docs/Web/CSS/background-image does not exist but fell back to /en-US/docs/Web/CSS/background-image
    • /pt-BR/docs/Web/CSS/background-position does not exist but fell back to /en-US/docs/Web/CSS/background-position
    • /pt-BR/docs/Web/CSS/background-repeat does not exist but fell back to /en-US/docs/Web/CSS/background-repeat
    • /pt-BR/docs/Web/CSS/CSS_animated_properties does not exist but fell back to /en-US/docs/Web/CSS/CSS_animated_properties
    • /pt-BR/docs/Web/CSS/background-image does not exist but fell back to /en-US/docs/Web/CSS/background-image
    • and 3 more flaws omitted
  • broken_links:
    • Can't resolve /pt-BR/docs/CSS/Using_CSS_gradients
    • Can't resolve /pt-BR/docs/CSS/Multiple_backgrounds
  • translation_differences:
    • Differences in the important macros (4 in common of 7 possible)

URL: /pt-BR/docs/Web/CSS/background-attachment
Title: background-attachment
Flaw count: 5

  • macros:
    • /pt-BR/docs/Web/CSS/background-image does not exist but fell back to /en-US/docs/Web/CSS/background-image
    • /pt-BR/docs/Web/CSS/CSS_animated_properties does not exist but fell back to /en-US/docs/Web/CSS/CSS_animated_properties
  • broken_links:
    • Can't resolve /pt-BR/docs/CSS
    • Can't resolve /pt-BR/docs/CSS/Multiple_backgrounds
  • translation_differences:
    • Differences in the important macros (4 in common of 9 possible)

URL: /fr/docs/Web/CSS/list-style-image
Title: list-style-image
Flaw count: 3

  • macros:
    • Wrong xref macro used (consider changing which macro you use). Error processing path /fr/docs/Web/CSS/:current
  • broken_links:
    • Can't resolve /fr/docs/Web/CSS/url()
  • translation_differences:
    • Differences in the important macros (5 in common of 9 possible)

URL: /fr/docs/Web/CSS/background-image
Title: background-image
Flaw count: 17

  • macros:
    • Wrong xref macro used (consider changing which macro you use). Error processing path /fr/docs/Web/CSS/:current
  • broken_links:
    • Anchor not lowercase
    • Can't resolve /fr/docs/Web/CSS/CSS_Images/Implementing_image_sprites_in_CSS
    • Can't resolve /fr/docs/Web/HTML/Element/Img
    • Can't resolve /fr/docs/Web/CSS/cross-fade()
    • Can't resolve /fr/docs/Web/CSS/element()
    • and 10 more flaws omitted
  • translation_differences:
    • Differences in the important macros (5 in common of 7 possible)

URL: /fr/docs/Web/CSS/background
Title: background
Flaw count: 4

  • macros:
    • Wrong xref macro used (consider changing which macro you use). Error processing path /fr/docs/Web/CSS/:current
  • broken_links:
    • Can't resolve /fr/docs/Web/CSS/CSS_Images/Using_CSS_gradients
    • Can't resolve /fr/docs/Web/CSS/CSS_Backgrounds_and_Borders/Using_multiple_backgrounds
  • translation_differences:
    • Differences in the important macros (5 in common of 7 possible)

URL: /fr/docs/Web/CSS/background-repeat
Title: background-repeat
Flaw count: 3

  • macros:
    • Wrong xref macro used (consider changing which macro you use). Error processing path /fr/docs/Web/CSS/:current
  • broken_links:
    • Can't resolve /fr/docs/Web/CSS/CSS_Backgrounds_and_Borders/Using_multiple_backgrounds
  • translation_differences:
    • Differences in the important macros (5 in common of 7 possible)

URL: /fr/docs/Web/CSS/list-style-position
Title: list-style-position
Flaw count: 2

  • macros:
    • Wrong xref macro used (consider changing which macro you use). Error processing path /fr/docs/Web/CSS/:current
  • translation_differences:
    • Differences in the important macros (5 in common of 7 possible)

URL: /fr/docs/Web/CSS/background-attachment
Title: background-attachment
Flaw count: 3

  • macros:
    • Wrong xref macro used (consider changing which macro you use). Error processing path /fr/docs/Web/CSS/:current
  • broken_links:
    • Can't resolve /fr/docs/Web/CSS/CSS_Backgrounds_and_Borders/Using_multiple_backgrounds
  • translation_differences:
    • Differences in the important macros (5 in common of 9 possible)

URL: /fr/docs/Web/CSS/background-position
Title: background-position
Flaw count: 4

  • macros:
    • Wrong xref macro used (consider changing which macro you use). Error processing path /fr/docs/Web/CSS/:current
  • broken_links:
    • Can't resolve /fr/docs/Web/CSS/background-position-inline
    • Can't resolve /fr/docs/Web/CSS/background-position-block
  • translation_differences:
    • Differences in the important macros (5 in common of 7 possible)

(comment last updated: 2024-12-10 15:57:22)

@leon-win
Copy link
Member

@OHMORIYUSUKE , thank you!

Looks good for ru (add some few suggestions) 👍

Copy link
Contributor

@jasonren0403 jasonren0403 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

handy update, however looks good overall👍

files/zh-cn/web/css/background-repeat/index.md Outdated Show resolved Hide resolved
@jasonren0403 jasonren0403 removed the request for review from JasonLamv-t November 26, 2024 06:30
@yin1999 yin1999 changed the title [es, fr, ja, ko, pt-br, ru, zh-cn, zh-tw]Corrected image file paths and demos paths [es, fr, ja, ko, pt-br, ru, zh-cn, zh-tw]: correct image file paths and demos paths Nov 26, 2024
Copy link
Collaborator

@mfuji09 mfuji09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ja のファイルについては良いと思います。

@Graywolf9 Graywolf9 requested review from Graywolf9 and removed request for Jalkhov November 26, 2024 22:12
Copy link
Contributor

@Graywolf9 Graywolf9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The paths looks good for es

Thank you so much!

@OHMORIYUSUKE
Copy link
Contributor Author

@1ilsang @cw118 @nathipg
Could you kindly review this when you have a moment?

Copy link
Member

@cw118 cw118 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the changes look good, thank you!

I have not had the time to test on my local machine, but could you confirm that the EmbedLiveSample work after adding the titles (e.g. "Exemple_simple")? There is a reason why empty strings were used in these macros in translated-content.

@1ilsang
Copy link
Member

1ilsang commented Dec 1, 2024

Looks good for ko. Thank you so much.

@OHMORIYUSUKE
Copy link
Contributor Author

@cw118

Most of the changes look good, thank you!

I have not had the time to test on my local machine, but could you confirm that the EmbedLiveSample work after adding the titles (e.g. "Exemple_simple")? There is a reason why empty strings were used in these macros in translated-content.

Thank you for the review!

The EmbedLiveSample works correctly. I confirmed it on my local machine.

There is a reason why empty strings were used in these macros in translated-content.

The display was not working as expected, so I fixed it in this pull request.
I referred to the following documentation when making the corrections:
https://developer.mozilla.org/en-US/docs/MDN/Writing_guidelines/Page_structures/Live_samples#grouping_code_blocks

I couldn't understand the reason why the macro was used with empty strings.My apologies.

Copy link
Member

@cw118 cw118 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The EmbedLiveSample works correctly. I confirmed it on my local machine.

Perfect, that should work then. We can confirm again once this is merged. Thanks very much for this @OHMORIYUSUKE !

In the past there were some strange issues with EmbedLiveSample in translated-content that required using empty strings, but it does seem that this is not a problem anymore (for the most part).

@OHMORIYUSUKE
Copy link
Contributor Author

@nathipg
Could you kindly review this when you have a moment?

@OHMORIYUSUKE
Copy link
Contributor Author

@josielrocha

You're not assigned as a reviewer, but if possible, could you kindly review it? Thank you in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-es Issues related to Spanish content. l10n-fr Issues related to French content. l10n-ja Issues related to Japanese content. l10n-ko Issues related to Korean content. l10n-pt-br Issues related to Brazilian Portuguese l10n-ru Issues related to Russian content. l10n-zh Issues related to Chinese content.
Projects
Status: In progress - PRs
Development

Successfully merging this pull request may close these issues.

list-style-image の例に画像が適用されていない
7 participants