-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[es, fr, ja, ko, pt-br, ru, zh-cn, zh-tw]: correct image file paths and demos paths #24765
base: main
Are you sure you want to change the base?
Conversation
Preview URLs (39 pages)
Flaws (197)Note! 2 documents with no flaws that don't need to be listed. 🎉 URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
(comment last updated: 2024-12-10 15:57:22) |
@OHMORIYUSUKE , thank you! Looks good for |
Co-authored-by: Leonid Vinogradov <[email protected]>
Co-authored-by: Leonid Vinogradov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
handy update, however looks good overall👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ja
のファイルについては良いと思います。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The paths looks good for es
Thank you so much!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of the changes look good, thank you!
I have not had the time to test on my local machine, but could you confirm that the EmbedLiveSample
work after adding the titles (e.g. "Exemple_simple"
)? There is a reason why empty strings were used in these macros in translated-content
.
Looks good for |
Thank you for the review! The EmbedLiveSample works correctly. I confirmed it on my local machine.
The display was not working as expected, so I fixed it in this pull request. I couldn't understand the reason why the macro was used with empty strings.My apologies. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The EmbedLiveSample works correctly. I confirmed it on my local machine.
Perfect, that should work then. We can confirm again once this is merged. Thanks very much for this @OHMORIYUSUKE !
In the past there were some strange issues with EmbedLiveSample in translated-content that required using empty strings, but it does seem that this is not a problem anymore (for the most part).
@nathipg |
You're not assigned as a reviewer, but if possible, could you kindly review it? Thank you in advance! |
Description
Issue #24373 has been addressed.
Other image files had also been changed. For example,
starsolid.gif
was renamed tostar-solid.gif
. Therefore, the file paths have been corrected.This problem occurs in the documentation for each language. All have been corrected in this Pull Request.
Motivation
If images and demos are not displayed correctly, they will confuse people referring to the document.
Additional details
Related issues and pull requests
Fixes #24373