[zh-cn]: update the translation of Location hash property
#24798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview URLs (comment last updated: 2024-12-13 12:43:01) |
JasonLamv-t
reviewed
Nov 27, 2024
JasonLamv-t
approved these changes
Nov 27, 2024
yin1999
reviewed
Nov 27, 2024
Comment on lines
21
to
25
| <a id="myAnchor" href="/zh-CN/docs/Location.href#示例">示例</a> | ||
| <script> | ||
| var anchor = document.getElementById("myAnchor"); | ||
| console.log(anchor.hash); // 返回'#Examples' | ||
| const anchor = document.getElementById("myAnchor"); | ||
| console.log(anchor.hash); // '#示例' | ||
| </script> |
There was a problem hiding this comment.
Is the example here appropriate?
The
Locationinterface is accessible via Document.location and Window.location respectively.
--- from TheLocationinterface
I don't think we should use an <a> element here, as <a> element is the implemetation of HTMLAnchorElement interface (not the Location interface).
Another issue on the content of this example. The hash property would be percent-encoded (see the test I made below), so the description above is also wrong 😢
It seems that only non-ascii characters will be encoded (details: mdn/content#37003)
T34-active
commented
Nov 29, 2024
|
This pull request has merge conflicts that must be resolved before it can be merged. |
github-actions
bot
added
the
merge conflicts 🚧
github-actions
bot
removed
the
merge conflicts 🚧
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues and pull requests