Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zh-CN: create topSites.get() #24892

Merged
merged 4 commits into from
Dec 14, 2024
Merged

zh-CN: create topSites.get() #24892

merged 4 commits into from
Dec 14, 2024

Conversation

PassionPenguin
Copy link
Contributor

No description provided.

@PassionPenguin PassionPenguin requested a review from a team as a code owner December 2, 2024 02:44
@PassionPenguin PassionPenguin requested review from t7yang and removed request for a team December 2, 2024 02:44
@github-actions github-actions bot added the l10n-zh Issues related to Chinese content. label Dec 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024 •
edited
Loading

Preview URLs

Flaws (13)

URL: /zh-CN/docs/Mozilla/Add-ons/WebExtensions/API/topSites/get
Title: topSites.get()
Flaw count: 13

  • macros:
    • /zh-CN/docs/Mozilla/Add-ons/WebExtensions/Background_scripts does not exist but fell back to /en-US/docs/Mozilla/Add-ons/WebExtensions/Background_scripts
    • /zh-CN/docs/Mozilla/Add-ons/WebExtensions/Working_with_files does not exist but fell back to /en-US/docs/Mozilla/Add-ons/WebExtensions/Working_with_files
    • /zh-CN/docs/Mozilla/Add-ons/WebExtensions/Differences_between_API_implementations does not exist but fell back to /en-US/docs/Mozilla/Add-ons/WebExtensions/Differences_between_API_implementations
    • /zh-CN/docs/Mozilla/Add-ons/WebExtensions/user_interface/Sidebars does not exist but fell back to /en-US/docs/Mozilla/Add-ons/WebExtensions/user_interface/Sidebars
    • /zh-CN/docs/Mozilla/Add-ons/WebExtensions/user_interface/Context_menu_items does not exist but fell back to /en-US/docs/Mozilla/Add-ons/WebExtensions/user_interface/Context_menu_items
    • and 8 more flaws omitted
External URLs (1)

URL: /zh-CN/docs/Mozilla/Add-ons/WebExtensions/API/topSites/get
Title: topSites.get()

(comment last updated: 2024-12-13 12:28:56)

yin1999
yin1999 reviewed Dec 7, 2024
View reviewed changes
Copy link
Member

@yin1999 yin1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

请先校对一遍

@yin1999 yin1999 marked this pull request as draft December 7, 2024 12:57
PassionPenguin
PassionPenguin commented Dec 9, 2024
View reviewed changes
files/zh-cn/mozilla/add-ons/webextensions/api/topsites/get/index.md Outdated Show resolved Hide resolved
files/zh-cn/mozilla/add-ons/webextensions/api/topsites/get/index.md Outdated Show resolved Hide resolved
files/zh-cn/mozilla/add-ons/webextensions/api/topsites/get/index.md Outdated Show resolved Hide resolved
files/zh-cn/mozilla/add-ons/webextensions/api/topsites/get/index.md Outdated Show resolved Hide resolved
files/zh-cn/mozilla/add-ons/webextensions/api/topsites/get/index.md Outdated Show resolved Hide resolved
files/zh-cn/mozilla/add-ons/webextensions/api/topsites/get/index.md Outdated Show resolved Hide resolved
files/zh-cn/mozilla/add-ons/webextensions/api/topsites/get/index.md Outdated Show resolved Hide resolved
files/zh-cn/mozilla/add-ons/webextensions/api/topsites/get/index.md Outdated Show resolved Hide resolved
@PassionPenguin PassionPenguin marked this pull request as ready for review December 9, 2024 11:20
yin1999
yin1999 reviewed Dec 11, 2024
View reviewed changes
Copy link
Member

@yin1999 yin1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

还有一些建议：

files/zh-cn/mozilla/add-ons/webextensions/api/topsites/get/index.md Outdated
Comment on lines 10 to 12
获取包含用户最近经常访问的页面信息的数组。

浏览器会保留用户经常访问的页面和最近访问的页面的列表。它们使用此列表来帮助用户轻松返回这些地方。例如，Firefox 默认提供了在“新标签”页中显示的最常访问页面的列表。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这两段的第一句描述的内容是类似的（英文文档），所以请确定并修改一下

Copy link
Contributor Author

@PassionPenguin PassionPenguin Dec 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

并不完全一致，第一句是对这个方法的功能描述：获取 topSites；第二段指出 topSites 是什么以及有什么用，第三、四段指出 topSites 的包含规则与过滤规则，第无端则具体指出这个方法获得的 topSites 会是怎么样的

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我说这两段的第一句话——“最近经常访问的页面”和“经常访问的页面和最近访问页面”等价吗。英文文档用的可都是“often and recently”。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

噢，你指的是句子里面，不好意思

files/zh-cn/mozilla/add-ons/webextensions/api/topsites/get/index.md Outdated Show resolved Hide resolved
files/zh-cn/mozilla/add-ons/webextensions/api/topsites/get/index.md Outdated Show resolved Hide resolved
files/zh-cn/mozilla/add-ons/webextensions/api/topsites/get/index.md Outdated Show resolved Hide resolved
files/zh-cn/mozilla/add-ons/webextensions/api/topsites/get/index.md Outdated Show resolved Hide resolved
files/zh-cn/mozilla/add-ons/webextensions/api/topsites/get/index.md Outdated Show resolved Hide resolved
files/zh-cn/mozilla/add-ons/webextensions/api/topsites/get/index.md Outdated Show resolved Hide resolved
files/zh-cn/mozilla/add-ons/webextensions/api/topsites/get/index.md Outdated Show resolved Hide resolved
files/zh-cn/mozilla/add-ons/webextensions/api/topsites/get/index.md Outdated Show resolved Hide resolved
files/zh-cn/mozilla/add-ons/webextensions/api/topsites/get/index.md Outdated Show resolved Hide resolved
yin1999
yin1999 approved these changes Dec 14, 2024
View reviewed changes
Copy link
Member

@yin1999 yin1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @PassionPenguin

@yin1999 yin1999 merged commit a52a2df into mdn:main Dec 14, 2024
7 checks passed
@PassionPenguin PassionPenguin deleted the topsites-1 branch December 14, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yin1999 yin1999 yin1999 approved these changes

@t7yang t7yang Awaiting requested review from t7yang t7yang is a code owner automatically assigned from mdn/yari-content-zh

Assignees
No one assigned
Labels
l10n-zh Issues related to Chinese content.
Projects
MDN translated-content l10n-zh
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PassionPenguin @yin1999