Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ja]: fixed to show demo #24927

Merged

Conversation

OHMORIYUSUKE
Copy link
Contributor

@OHMORIYUSUKE OHMORIYUSUKE commented Dec 3, 2024

Description

デモが正しく表示されていなかったので修正しました。
https://developer.mozilla.org/ja/docs/Learn/CSS/First_steps/How_CSS_is_structured

Motivation

Additional details

Related issues and pull requests

Fixes #24722

@OHMORIYUSUKE OHMORIYUSUKE requested a review from a team as a code owner December 3, 2024 15:55
@OHMORIYUSUKE OHMORIYUSUKE requested review from mfuji09 and removed request for a team December 3, 2024 15:55
@github-actions github-actions bot added the l10n-ja Issues related to Japanese content. label Dec 3, 2024
Copy link
Contributor

github-actions bot commented Dec 3, 2024

Preview URLs

Flaws (40)

URL: /ja/docs/Learn/CSS/First_steps/How_CSS_is_structured
Title: CSS の構造
Flaw count: 40

  • macros:
    • /ja/docs/Games/Publishing_games does not exist but fell back to /en-US/docs/Games/Publishing_games
    • /ja/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_interactivity_events_state does not exist but fell back to /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_interactivity_events_state
    • /ja/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_interactivity_filtering_conditional_rendering does not exist but fell back to /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_interactivity_filtering_conditional_rendering
    • /ja/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_accessibility does not exist but fell back to /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_accessibility
    • /ja/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/Ember_getting_started does not exist but fell back to /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/Ember_getting_started
    • and 34 more flaws omitted
  • translation_differences:
    • Differences in the important macros (3 in common of 5 possible)

(comment last updated: 2024-12-08 16:48:44)

Copy link
Collaborator

@mfuji09 mfuji09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EmbedLiveSample の ID を変更すると flaws として報告されてしまうので、コードブロック側に ID を付与することで修正した方が良いと思います。

例えば、292行目、296行目に対して、次のような形でIDを付与すると、サンプルコードが正しく表示できるようになります。

```html live-sample___the_calc_function
```css live-sample___the_calc_function

live-sample___ の後に、EmbedLiveSample で指定したIDヲ小文字化したものをつけてください。

@OHMORIYUSUKE OHMORIYUSUKE requested a review from mfuji09 December 8, 2024 16:32
@OHMORIYUSUKE OHMORIYUSUKE marked this pull request as draft December 8, 2024 16:36
@OHMORIYUSUKE OHMORIYUSUKE force-pushed the fix/First_steps_How_CSS_is_structured branch from 721b99b to 632ded7 Compare December 8, 2024 16:39
@OHMORIYUSUKE OHMORIYUSUKE reopened this Dec 8, 2024
@OHMORIYUSUKE OHMORIYUSUKE marked this pull request as ready for review December 8, 2024 16:47
@OHMORIYUSUKE
Copy link
Contributor Author

@mfuji09
da747ca
ありがとうございます。修正しました。

Copy link
Collaborator

@mfuji09 mfuji09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

修正ありがとうございました。OKです。

@mfuji09 mfuji09 merged commit dae5170 into mdn:main Dec 12, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-ja Issues related to Japanese content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

回答の誤表示
2 participants