Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ko] Working with the History API 번역 업데이트 #25139

Conversation

effozen
Copy link
Contributor

@effozen effozen commented Dec 18, 2024

Description

Working with the History API 문서의 최신 업데이트 내용을 반영해서, 번역을 갱신하였습니다.

Motivation

History API 학습 중 최신 정보가 반영되어 있지 않아, 불편함을 느껴 개선하게 되었습니다.

Additional details

Related issues and pull requests

@effozen effozen requested a review from a team as a code owner December 18, 2024 00:15
@effozen effozen requested review from wisedog and removed request for a team December 18, 2024 00:15
@github-actions github-actions bot added the l10n-ko Issues related to Korean content. label Dec 18, 2024
Copy link
Contributor

github-actions bot commented Dec 18, 2024

Preview URLs

Flaws (1)

URL: /ko/docs/Web/API/History_API/Working_with_the_History_API
Title: History API로 작업하기
Flaw count: 1

  • macros:
    • /ko/docs/Web/API/PopStateEvent/state does not exist but fell back to /en-US/docs/Web/API/PopStateEvent/state

(comment last updated: 2024-12-24 08:57:27)

@wisedog
Copy link
Contributor

wisedog commented Dec 18, 2024

일단 첫 기여 감사드립니다! 빠른 시일 내에 리뷰드리도록 하겠습니다.

Copy link
Contributor

@wisedog wisedog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

기여 감사합니다! 첫 기여이신데, 상당히 매끄럽게 잘 PR을 해주셔서 놀랬습니다.

앞으로도 잘 부탁드립니다. 몇 가지 소소한 수정사항을 남겼으니 수정 부탁드릴께요.

@effozen effozen requested a review from wisedog December 24, 2024 10:46
Copy link
Contributor

@wisedog wisedog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wisedog wisedog merged commit 58588a5 into mdn:main Dec 26, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-ko Issues related to Korean content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants