Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tool): add "remove" alias to "tool delete" #10077

Closed
wants to merge 1 commit into from

Conversation

queengooborg
Copy link
Collaborator

Summary

This PR adds a remove (and rm) alias to the yarn tool delete command.

Problem

I often accidentally type yarn content remove ... when attempting to remove and redirect a page in MDN content. This is because remove is the more common phrase used in development.

Solution

The solution is simple: to alias the delete command. This will allow the use of remove (or rm), without impacting the workflow of existing users.


How did you test this change?

Just ran yarn tool remove and yarn tool rm and made sure it outputs the same message as yarn tool delete.

@queengooborg queengooborg requested a review from a team as a code owner November 25, 2023 07:20
@github-actions github-actions bot added the idle label Jan 24, 2024
@caugner caugner changed the title Add "remove" alias to "tool delete" chore(tool): add "remove" alias to "tool delete" Jan 25, 2024
@github-actions github-actions bot removed the idle label Jan 27, 2024
@github-actions github-actions bot added the idle label Feb 28, 2024
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We (@argl @fiji-flo @caugner) took a look and appreciate the suggestion but decided to reject the change.

If there is a majority to rename the command, we can rename it to remove. Otherwise we recommend using a shell alias locally.

@caugner caugner closed this Mar 28, 2024
@queengooborg
Copy link
Collaborator Author

Why? This is not renaming the existing command. This is only adding an alias.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants