enhance(ai-help): add model to issue reports #10925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
plus
caugner
commented
Apr 15, 2024
Comment on lines
+1086
to
+1087
| const user = useUserData(); | ||
| const isSubscriber = useMemo(() => isPlusSubscriber(user), [user]); |
There was a problem hiding this comment.
Mirrored from here:
yari/client/src/plus/ai-help/banners.tsx
Lines 12 to 14 in 26ed0e5
As `[].join("\n")` is never `null`, this wasn't working so far.
caugner
commented
Apr 15, 2024
| @@ -1105,8 +1108,10 @@ function ReportIssueOnGitHubLink({ | |||
| (source) => | |||
| `- [${source.title}](https://developer.mozilla.org${source.url})` | |||
| ) | |||
| .join("\n") ?? "(None)" | |||
| .join("\n") || "(None)" | |||
argl
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
(MP-1037)
Problem
When users report issues with AI Help answers, we don't know if these answers were generated by GPT-3.5 or GPT-4.
Solution
Add a parameter to the issue template links to record the used model.
How did you test this change?
Verified locally by running yari alongside rumba and clicking on the issue report link, both with a free user and a paying subscriber, and observed the field to be pre-filled with "gpt-3.5" and "gpt-4" respectively.