Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(readme): remove ngrok section #11164

Merged
merged 1 commit into from
Jun 6, 2024
Merged

chore(readme): remove ngrok section #11164

merged 1 commit into from
Jun 6, 2024

Conversation

caugner
Copy link
Contributor

@caugner caugner commented May 20, 2024

Summary

Replaces #11136.

Problem

The README recommends ngrok, but we haven't been using it, and don't need to feature it.

Solution

Remove the section.


How did you test this change?

Looked at https://github.com/mdn/yari/blob/10154d677ef9d903d5d07bd4589fd965f4159487/README.md.

@caugner caugner requested a review from a team as a code owner May 20, 2024 14:26
Copy link
Contributor Author

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-approval (checked with @fiji-flo and @argl).

@caugner caugner merged commit 0cae8bd into main Jun 6, 2024
13 checks passed
@caugner caugner deleted the remove-ngrok-from-readme branch June 6, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant