Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(baseline): update learn more link to glossary entry #11532

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

LeoMcA
Copy link
Member

@LeoMcA LeoMcA commented Jul 24, 2024

Summary

https://mozilla-hub.atlassian.net/browse/MP-1272

Problem

Baseline banner was linking to rather old blog post

Solution

Link to the maintained, and up to date glossary entry

Disabled noreferrer rule for link, as it's internal (eslint can't detect this because its dynamic), and it's actually useful to have referrer data here.


Screenshots

No change


How did you test this change?

  • yarn && yarn dev
  • localhost:3000
  • tested across locales: those with a glossary page go there directly, those without recommend going to the english glossary page

@LeoMcA LeoMcA requested a review from a team as a code owner July 24, 2024 11:14
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although for locales where that Baseline Glossary page isn't written, it will link to a 404 page, but there's no easy fix.

@LeoMcA LeoMcA changed the title enhance(baseline): update learn more link to glossary entry chore(baseline): update learn more link to glossary entry Jul 24, 2024
@LeoMcA LeoMcA merged commit a291a6a into main Jul 24, 2024
14 checks passed
@LeoMcA LeoMcA deleted the baseline-link-glossary branch July 24, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants