This repository was archived by the owner on Jan 18, 2023. It is now read-only.
Makes marathon_client gem available to LWRP #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 29, 2014 22:03
Fixes issue where require statement in LWRP would fail due to unavailable marathon_client gem. Gem is installed during parsing of LWRP at compile time. Gems have been updated along with their corresponding files, which includes style and tests.
| @@ -16,9 +16,20 @@ | |||
| # limitations under the License. | |||
| # | |||
|
|
|||
| Chef::Log.info('Checking if gem marathon_client 0.2.3 is installed...') | |||
| unless `gem list marathon_client -v 0.2.3 -i`.strip == 'true' | |||
There was a problem hiding this comment.
You could use Chef::Resource::ChefGem here?
http://www.rubydoc.info/github/opscode/chef/Chef/Resource/ChefGem
There was a problem hiding this comment.
I'll see if I can make that work, it would definitely be preferred.
|
LGTM. Fancy a merge @harryw? |
|
Hold off on merge, want to test something. |
|
👍 |
harryw
pushed a commit
that referenced
this pull request
Oct 31, 2014
Makes marathon_client gem available to LWRP
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19
Fixes issue where require statement in LWRP would fail due to
unavailable marathon_client gem. Gem is installed during parsing of
LWRP at compile time. Gems have been updated along with their
corresponding files, which includes style and tests.