Skip to content

Commit

Permalink
1511 enable custom template set group ids for lookup (devonfw#1535)
Browse files Browse the repository at this point in the history
* devonfw#1511 added new method to read properties in ConfigurationFinder.java
new TemplateSetConfiguration Class to save properties
new test cases in ConfigurationFinderTest.java

* devonfw#1511 fixed logic in method readTemplateSetConfiguration in ConfigurationFinder
added hideTemplates variable in TemplateSetConfiguration
completed 2 out of 3 tests cases

* devonfw#1511 corrected CheckTemplateSetConfiguration logic in ConfigurationFinder.java
Test cases Correction for CheckTemplateSetConfiguration in ConfigurationFinderTest.java
New Constants for the new properties created in ConfigurationConstants.java
CheckTemplateSetConfiguration Called in load function in CobiGenPropertiesReader.java

* devonfw#1511 canceled the method call in load properties in CobiGenPropertiesReader.java

* devonfw#1511 written Documentation
Modified the properties function to read properties
corrected tests

* devonfw#1511 documentation correction

* devonfw#1511 Documentation correction

* devonfw#1511 Documentation Correction

* devonfw#1511 requested changes

* devonfw#1511 requested changes #2

* devonfw#1511 requested changes 2

* devonfw#1511 requested changes

* devonfw#1511 fix defaultGroupId logic

* devonfw#1511 corrected hide annotation

* devonfw#1511 requested changes
  • Loading branch information
mdukhan authored May 13, 2022
1 parent a1ca29a commit 6c61401
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ public void validConfigurationTest() {
assertThat(conf.getGroupIds()).containsSequence("devonfw-cobigen-bla", "abcd", "blablob",
ConfigurationConstants.CONFIG_PROPERTY_TEMPLATE_SETS_DEFAULT_GROUPID);
assertThat(conf.isAllowSnapshots()).isTrue();
assertThat(conf.getHideTemplates()).contains("com.devonfw(:test-artifact(:3.2.1-SNAPSHOT))");
assertThat(conf.getHideTemplates()).contains("com.devonfw:test-artifact:3.2.1-SNAPSHOT");
}

/**
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
template-sets.groupIds=devonfw-cobigen-bla,abcd,blablob
template-sets.allow-snapshots=true
template-sets.disable-default-lookup=false
template-sets.hide=com.devonfw(:test-artifact(:3.2.1-SNAPSHOT))
template-sets.hide=com.devonfw:test-artifact:3.2.1-SNAPSHOT
2 changes: 1 addition & 1 deletion documentation/cobigen-core_configuration.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -354,7 +354,7 @@ configure multiple (comma separated) `groupIds`. By default, (public) CobiGen `g
template-sets.groupIds=com.devonfw.cobigen.templates,jaxen,jakarta.xml.bind
template-sets.allow-snapshots=true
template-sets.disable-default-lookup=false
template-sets.hide=com.devonfw(:test-artifact(:3.2.1-SNAPSHOT))
template-sets.hide=com.devonfw.cobigen.templates:crud-angular-client-app:2021.12.007-SNAPSHOT
```

== Basic Template Model
Expand Down

0 comments on commit 6c61401

Please sign in to comment.