Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: fix GH Actions node deprecation #4306

Merged

Conversation

Choromanski
Copy link
Contributor

@Choromanski Choromanski commented Oct 1, 2024

What type of PR is this?

  • cleanup
  • feature

What this PR does / why we need it:

Github Actions are running on deprecated node versions.
CodeQL Action v2 deprecated in December

Special notes for your reviewer:

All of these warnings are from using a deprecated version of node:
image

Testing

Tests will be shown in the build for this PR
Current warnings:
image

@github-actions github-actions bot added the bugfix label Oct 1, 2024
@Choromanski Choromanski marked this pull request as ready for review October 2, 2024 00:59
@boc-the-git boc-the-git enabled auto-merge (squash) October 2, 2024 01:21
Copy link
Collaborator

@boc-the-git boc-the-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@boc-the-git boc-the-git merged commit fef3f1c into mealie-recipes:mealie-next Oct 2, 2024
14 checks passed
@Kuchenpirat Kuchenpirat changed the title fix: GH Actions node deprecation dev: fix GH Actions node deprecation Oct 19, 2024
@Kuchenpirat Kuchenpirat added dev Internal development and removed bugfix labels Oct 19, 2024
@Choromanski Choromanski deleted the feature/node-20-deprecated branch October 23, 2024 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev Internal development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants