fix: Only run migration data fixes on migrations #5038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
(REQUIRED)
Resolves slow start times on large instances by not checking for data fixes on every boot. We now only check for migration data issues after doing a migration.
I opted not to pin these to a particular migration since we still haven't nailed the root causes down for some of these, but at least now it will only run on upgrades or data restores, so normal teardowns/rebuilds won't take forever.
Which issue(s) this PR fixes:
(REQUIRED)
Fixes #4610
Special notes for your reviewer:
(fill-in or delete this section)
Testing
(fill-in or delete this section)
Eyeballing
task py