feat: Exposing header/canvas components #887
Open
+270
−203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@shannonhochkins is attempting to deploy a commit to the Measured Team on Vercel. A member of the Team first needs to authorize it. |
shannonhochkins
changed the title
|
I just noticed the loadedOverrides in the main Puck component too, which is obviously a bug with this PR as the header will not be overridable via a plugin currently |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix issue.
Next Steps:
Before proceeding with detailed documentation and further refinements, I seek feedback on the proposed changes to ensure alignment with the project's goals and to assess the likelihood of this PR being merged.
I did test this with the demo app, both components render, obviously because the Canvas component isn't rendered in the standard UI, it does require additional css to stretch the Canvas element to fill the viewport, again something we can clean up after feedback!