Refactor peerRefreshDNS() to clarify its (void*)1 logic #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rousskov
changed the base branch from
master
to
SQUID-770-remove-always-false-readBody-condition
rousskov
changed the base branch from
SQUID-770-remove-always-false-readBody-condition
to
master
rousskov
changed the title
rousskov
requested changes
Nov 18, 2024
and also polished, reducing duplication.
rousskov
requested changes
Nov 19, 2024
src/neighbors.cc
Outdated
| /* Reconfigure the peers every hour */ | ||
| eventAddIsh("peerRefreshDNS", peerRefreshDNS, nullptr, 3600.0, 1); | ||
| static void | ||
| peerScheduleDnsRefreshCheck(const double delayInSeconds) |
There was a problem hiding this comment.
Please try to move this up, where the old eventFind() was, to simplify the diff.
src/neighbors.cc
Outdated
|
|
||
| static void | ||
| peerDnsRefreshCheck(void *data) | ||
| { | ||
| if (!data && 0 == stat5minClientRequests()) { |
There was a problem hiding this comment.
I assume you are working on removing data from this condition and will come back to this PR after that is done.
src/neighbors.cc
Outdated
|
|
||
| /* Reconfigure the peers every hour */ |
There was a problem hiding this comment.
Let's drop this misleading comment. This self-documented code is not reconfiguring cache_peers. The only problem here is that 3600.0 constant lacks "this is an hour" annotation, but that will be fixed when we migrate this code to std::chrono.
Suggested change
| /* Reconfigure the peers every hour */ |
that will be fixed when we migrate this code to std::chrono
I do not think we should migrate in this PR, but we will migrate if others insist.
|
This work became official PR 1950. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating a raw pointer with 1 as an address/value raised red flags, and
it was difficult to interpret tricky peerRefreshDNS() logic correctly.