Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MBS-9395: Fix pagination on userstats table #20

Merged
merged 7 commits into from
Oct 2, 2024

Conversation

TobiGa
Copy link
Contributor

@TobiGa TobiGa commented Sep 26, 2024

No description provided.

Copy link
Member

@PhMemmel PhMemmel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think also the upper set_count_sql in line 101 is broken? I think this should also be fixed.

@TobiGa
Copy link
Contributor Author

TobiGa commented Oct 1, 2024

I think also the upper set_count_sql in line 101 is broken? I think this should also be fixed.

I changed it to resemble the select query.

classes/local/userstats_table.php Outdated Show resolved Hide resolved
classes/local/userstats_table.php Outdated Show resolved Hide resolved
classes/local/userstats_table.php Outdated Show resolved Hide resolved
purpose_statistics.php Show resolved Hide resolved
@PhMemmel PhMemmel force-pushed the MBS-9395-fix-pagination-bug branch from b00947d to f2e59f1 Compare October 2, 2024 08:53
@PhMemmel PhMemmel merged commit a79fa27 into main Oct 2, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants