MBS-8586: Simplify horizontal scrolling #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
PhMemmel
requested changes
Jan 17, 2024
There was a problem hiding this comment.
Looks good in general.
Some minor questions/thoughts/suggestions:
- Would it be a good idea to make the steps when clicking the buttons dependent on the card with? Currently it feels a bit like I have to click too often to move right, so maybe we can use cardwith/2 as scroll length or even 0.9*cardwith or something?
- To fit into the overall design maybe we could style the buttons with rounded corners.
- It would be nice if the buttons could be transparent, so when they are shown, you can still see the content of the card behind them
- User might eventually expect that I can keep scrolling by keeping the buttons pressed. Is this something we want?
styles.css
Outdated
|
|
||
| .mod_kanban_scroll_right { | ||
| left: calc(100vw - 30px); | ||
| } |
sh-csg
force-pushed
the
MBS-8586-Simplify-horizontal-scrolling
branch
from
2a223fe to
7b396a6
Compare
|
Introducing transparency produces a quite messy output - maybe we'll find another approach for implementing |
sh-csg
force-pushed
the
MBS-8586-Simplify-horizontal-scrolling
branch
from
7b396a6 to
0e33f83
Compare
sh-csg
force-pushed
the
MBS-8586-Simplify-horizontal-scrolling
branch
from
0e33f83 to
5506e84
Compare
PhMemmel
reviewed
Feb 1, 2024
amd/src/board.js
Outdated
| } else { | ||
| this.getElement(selectors.SCROLLLEFT).style.setProperty('visibility', 'visible'); | ||
| } | ||
| if (main.scrollLeft < main.scrollLeftMax) { |
There was a problem hiding this comment.
Not a standard property, does not work on Chrome and many other browsers, see: https://developer.mozilla.org/en-US/docs/Web/API/Element/scrollLeftMax?retiredLocale=de
Needs to be changed.
sh-csg
force-pushed
the
MBS-8586-Simplify-horizontal-scrolling
branch
from
5506e84 to
48b3ebe
Compare
|
Accidentally pushed wrong version - sorry for that! |
sh-csg
force-pushed
the
MBS-8586-Simplify-horizontal-scrolling
branch
from
48b3ebe to
34a7e55
Compare
sh-csg
force-pushed
the
MBS-8586-Simplify-horizontal-scrolling
branch
5 times, most recently
from
386a094 to
8a80298
Compare
sh-csg
force-pushed
the
MBS-8586-Simplify-horizontal-scrolling
branch
from
8a80298 to
9b283d9
Compare
PhMemmel
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.