-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MBS-8967: Add modal to show errors when trying to change sth #46
Conversation
Failing GHA is not related to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixes part of the issue when trying to do for example things you aren't allowed to.
However, the error handling should be implemented for every webservices call, also for the permanent update polls for example. Currently, if for testing purposes I insert an exception into get_kanban_content_update
the app will just crash.
The error handling should properly handle the issue of connection loss.
Maybe it's also possible/easier to use displayException
function?
Added an alert for displaying connection loss. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few comments. Have not tested yet.
b44e867
to
5791dad
Compare
068d9ff
to
5afced9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to work well so far, good job!
Would it be difficult to implement a feedback for actions the user is doing? If he tries to create a card for example there is no feedback if this action is being queued or it's just being ignored or what happens with it.
Another solution would be to disable the UI completely until the connection is back up.
Thoughts?
Yes |
What a pity! Then I'll raise a separate ticket for this ;-) |
d8782b6
to
f86fd2a
Compare
f86fd2a
to
7dcf7a5
Compare
In theory we would have to wrap each ajax with a try catch to avoid all JS console errors. The major ones now have been wrapped, rest is fine for throwing JS console errors when there's a big red banner showing that connection has been lost :) |
Implements #14