Platform.js is old and causing issue with OS version - updating platform.js to latest #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
We have identified an issue within our React project which employs Module Federation. The project consists of multiple modules that rely on ally.js for accessibility features.
The common library is loaded as a script tag, the shell application, and a federated module; all these make use of ally.js in different capacities.
This setup led to a conflict due to loading versions of a shared dependency, platform.js.
Proposed Solution
The PR includes an update to the platform.js dependency.
The upgrade to platform.js from 1.3.3 to 1.3.6 aims to resolve the conflict.
Testing
After the upgrade, the application was tested in an integrated environment to ensure that the ally.js functions correctly in all scenarios - both in the common library, the shell application, and the federated modules. No errors related to platform.js were encountered post-upgrade.
Request
We request a review of the changes and welcome any feedback on the upgrade. If there are no objections, we would appreciate a timely merge to prevent this issue from impacting others.
Related Issues #179. and mine.