Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/35439 integrate vat tax include in price config into service application #13

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Feature/35439 integrate vat tax include in price config into service application #13

wants to merge 6 commits into from

Conversation

630N
Copy link
Contributor

@630N 630N commented Feb 16, 2024

No description provided.

@alimohsenimopt
#35439
521ac4d 
- Tests refactored and simplified to make it possible to reuse
- Integrate tax included prices logic into post process logic
- New tests added for tax included prices
@alimohsenimopt
#35439
fbd270e 
- Small improvements
- VAT Requirements integrated
- Cart and Order requests enriched by VAT requirements
- Minor fixes
@alimohsenimopt
#35439
52806e2 
- Custom fields added into response
- Tests refactored
@630N 630N requested a review from mbe1987 February 16, 2024 08:42
mbe1987
mbe1987 requested changes Feb 16, 2024
View reviewed changes
event/src/avalara/requests/preprocess/preprocess.order.ts Outdated Show resolved Hide resolved
event/src/avalara/requests/preprocess/preprocess.order.ts Outdated Show resolved Hide resolved
event/src/controllers/event.controller.ts Outdated Show resolved Hide resolved
event/src/controllers/event.controller.ts Outdated Show resolved Hide resolved
event/src/controllers/event.controller.ts Outdated Show resolved Hide resolved
service/src/avalara/requests/preprocess/preprocess.get.tax.ts Outdated Show resolved Hide resolved
event/tests/event.spec.ts Outdated Show resolved Hide resolved
service/src/avalara/requests/preprocess/preprocess.get.tax.ts Outdated Show resolved Hide resolved
@alimohsenimopt
#35439
6679959 
- Fixes and improvements
- Refactoring after review
@alimohsenimopt
#35439
a2d7a78 
- Another fix
@alimohsenimopt
#35439
676dd15 
- Remove dangling codes and logics
mbe1987
mbe1987 approved these changes Feb 19, 2024
View reviewed changes
Copy link
Contributor

@mbe1987 mbe1987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will approve the pull request already, but have two remarks:

  • there is a small chang requested inline
  • you should talk to Valeria concerning using the setCustomFieldAction instead of the setCustomTypeAction to keep already stored custom fields of the objects

event/src/avalara/requests/postprocess/postprocess.order.commit.ts Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@realnaliboh realnaliboh realnaliboh left review comments

@mbe1987 mbe1987 mbe1987 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@630N @mbe1987 @realnaliboh @alimohsenimopt