fix: handshake stalls on PDP/A controllers (undercontrol and some other noname brands) #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…chunks and rumble initialization too early (before handshake is properly handled) Added an authenticated callback to gamepad device that triggers rumble/input initialization. TODO: handle authentication failure in newly created authenticated callback in gamepad. bus/protocol: add handling of final ACME on chunked reliable messages auth/gamepad: add authenticated event to enable input only when gamepad has finished its handshake wired: increase USB DATA URB to 12 to prevent starving in key exchanges during handshake .gitignore: remove Microsoft spec from git repo
|
This is a pull request for the issue I had with a generic gamepad (id 20d6/a01a) which failed during handshake. When I corrected that behavior I had ENOSPC errors due to all URBs beeing consumed in the pub key exchange that took more than the initial 8. Increased to 12. These controller abort current command when submitted with a new one, so I needed to delay rumble initialization & input handling initialization after the handshake phase is done otherwise the handshake would break down. This is a cleaner PR than the initial one submitted a few month earlier. |
ykpmusicstudio
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an authenticated callback to gamepad device that delays rumble/input initialization after authentication is finished.
bus/protocol: add handling of final ACME on chunked reliable messages (as per microsoft spec)
auth/gamepad: add authenticated event to delay input initialization after gamepad has successfully finished its handshake
wired: increase USB DATA URB to 12 to prevent starving in key exchanges during handshake (urb depletions for less than 12)
.gitignore: remove Microsoft spec from git repo