Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix relative links URLs in iOS Simulator article #23

Merged
merged 2 commits into from
Nov 19, 2023

Conversation

meduzen
Copy link
Owner

@meduzen meduzen commented Nov 19, 2023

No description provided.

@meduzen meduzen added the bug Something isn't working label Nov 19, 2023
@meduzen meduzen self-assigned this Nov 19, 2023
Copy link

what-the-diff bot commented Nov 19, 2023

PR Summary

  • Enabling Root Directory Based Image Paths
    The image paths in the files macos-sonoma-download-xcode-simulators-slow-bandwidth.md and recover-a-lost-git-stash.md have been adjusted. Instead of being linked to the ../public directory, these images are now relative to the root directory. This simplifies the file structure and makes it easier to manage and add new images in the future.

  • Adaptation of link testing
    To accommodate the changes in image paths, the arguments in .github/workflows/links.yml and test:absolute-links script in package.json have been modified. The introduction of the --base ./vitepress/public argument ensures that the link testing framework accurately verifies all links, even with the updated image path structure.

Copy link

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Everything 7.05 MB (-48.03% 🔽) 144.5 s (-48.03% 🔽) 9.3 s (-11.17% 🔽) 153.7 s
Assets (excluding CSS and JS) 378.48 KB (-94.64% 🔽) 7.6 s (-94.64% 🔽) 0 ms (+100% 🔺) 7.6 s
CSS 15.1 KB (0%) 303 ms (0%) 0 ms (+100% 🔺) 303 ms
JavaScript 78.76 KB (-0.2% 🔽) 1.6 s (-0.2% 🔽) 7.8 s (-19.22% 🔽) 9.4 s
Articles 20.76 KB (-0.56% 🔽) 416 ms (-0.56% 🔽) 0 ms (+100% 🔺) 416 ms
Notes 20.47 KB (-0.08% 🔽) 410 ms (-0.08% 🔽) 0 ms (+100% 🔺) 410 ms
Media for articles and notes 6.52 MB (0%) 133.5 s (0%) 0 ms (+100% 🔺) 133.5 s
Feeds 10.2 KB (-0.18% 🔽) 205 ms (-0.18% 🔽) 0 ms (+100% 🔺) 205 ms

@meduzen meduzen merged commit fb90a85 into main Nov 19, 2023
2 checks passed
@meduzen meduzen deleted the fix/public-content-path branch November 19, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant