Skip to content

Commit

Permalink
Bugfix for Hover which is visible above other application windows. ec…
Browse files Browse the repository at this point in the history
…lipse-platform#2534

This patch is fixing the problem, where the HoverManagers listeners are
deregistered but the hover is still visibile on top. This happens when
the hover was sticky eclipse was minimized and put back on foreground
after it. In that case the listeners are already deregistered and there
is no chance to react at all. So for this case the visibility has to be
set explicitly when the close is going to stop.
Version bump(s) for 4.35 stream
Bugfix for Hover which is visible above other application windows. eclipse-platform#2534
  • Loading branch information
mehmet-karaman committed Nov 25, 2024
1 parent 7aaa014 commit b93e2df
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 2 deletions.
2 changes: 1 addition & 1 deletion bundles/org.eclipse.jface.text/META-INF/MANIFEST.MF
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Manifest-Version: 1.0
Bundle-ManifestVersion: 2
Bundle-Name: %pluginName
Bundle-SymbolicName: org.eclipse.jface.text
Bundle-Version: 3.26.0.qualifier
Bundle-Version: 3.26.100.qualifier
Bundle-Vendor: %providerName
Bundle-Localization: plugin
Export-Package:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
import org.eclipse.swt.widgets.Control;
import org.eclipse.swt.widgets.Display;
import org.eclipse.swt.widgets.Monitor;
import org.eclipse.swt.widgets.Shell;

import org.eclipse.core.runtime.Assert;
import org.eclipse.core.runtime.Platform;
Expand Down Expand Up @@ -1210,8 +1211,15 @@ protected void hideInformationControl() {
if (fInformationControl != null) {
storeInformationControlBounds();
fInformationControl.setVisible(false);
if (fInformationControlCloser != null)
if (fInformationControlCloser != null) {
fInformationControlCloser.stop();
}
if (fInformationControl instanceof AbstractInformationControl infoControl) {
Shell shell= infoControl.getShell();
if (!shell.isDisposed()) {
shell.setVisible(false);
}
}
}
if (canClearDataOnHide()) {
fSubjectArea= null;
Expand Down

0 comments on commit b93e2df

Please sign in to comment.